Pass --check-signatures to test executions of lld and
fix resulting errors.
Details
Diff Detail
- Repository
- rLLD LLVM Linker
- Build Status
Buildable 14367 Build 14367: arc lint + arc unit
Event Timeline
I don't have enough knowledge to review this, but do you need a pre-commit code review for this?
Perhaps no review needed. I tend to prefer pre-commit reviews for pretty much all changes, although I understand llvm is less strict about this than other projects.
I've been adding you you as a reviewer to pretty much all my changes, even these smaller ones, mostly just to keep you in the loop. If you'd like to use other people for the more trivial changes I certainly can. And also feel free to remove yourself from the reviewer list any time.. I won't be offended.
Looks nice and harmless.
I guess I should be adding Rui as reviewer on my changes too? I've just been adding Sam currently as the "code owner" for Wasm LLD, on the basis that Sam can add someone else if he wants to do less reviewing, and the people who need to be notified should all be getting the Phabricator spam via Herald subscriptions.