This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix signature mismatches in test code. NFC.
ClosedPublic

Authored by sbc100 on Jan 29 2018, 2:53 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jan 29 2018, 2:53 PM
sbc100 retitled this revision from [WebAssembly] Fix signature mismatches in test code to [WebAssembly] Fix signature mismatches in test code. NFC..Jan 30 2018, 5:38 PM
sbc100 added reviewers: ruiu, ncw.
sbc100 updated this revision to Diff 132095.Jan 30 2018, 7:26 PM
  • rebase
ruiu added a comment.Jan 30 2018, 7:40 PM

I don't have enough knowledge to review this, but do you need a pre-commit code review for this?

In D42661#992800, @ruiu wrote:

I don't have enough knowledge to review this, but do you need a pre-commit code review for this?

Perhaps no review needed. I tend to prefer pre-commit reviews for pretty much all changes, although I understand llvm is less strict about this than other projects.

I've been adding you you as a reviewer to pretty much all my changes, even these smaller ones, mostly just to keep you in the loop. If you'd like to use other people for the more trivial changes I certainly can. And also feel free to remove yourself from the reviewer list any time.. I won't be offended.

ncw accepted this revision.Jan 31 2018, 2:34 AM

Looks nice and harmless.

I guess I should be adding Rui as reviewer on my changes too? I've just been adding Sam currently as the "code owner" for Wasm LLD, on the basis that Sam can add someone else if he wants to do less reviewing, and the people who need to be notified should all be getting the Phabricator spam via Herald subscriptions.

This revision is now accepted and ready to land.Jan 31 2018, 2:34 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.