- truncate symbols from static/dynamic index to the limited number
(which would save lots of cost in constructing the merged symbols).
- add an CLI option allowing to limit the number of returned completion results.
(default to 100)
Paths
| Differential D42484
[clangd] Limit completion results. ClosedPublic Authored by hokein on Jan 24 2018, 8:05 AM.
Details Summary
(which would save lots of cost in constructing the merged symbols).
(default to 100)
Diff Detail
Event TimelineHerald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. · View Herald TranscriptJan 24 2018, 8:05 AM Comment Actions Thank you!
This revision is now accepted and ready to land.Jan 24 2018, 8:10 AM hokein marked 4 inline comments as done. Comment ActionsAddress review comments.
Closed by commit rL323408: [clangd] Limit completion results. (authored by hokein). · Explain WhyJan 25 2018, 1:24 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 131271 clangd/CodeComplete.cpp
clangd/index/Merge.cpp
clangd/tool/ClangdMain.cpp
unittests/clangd/CodeCompleteTests.cpp
|
nit: our flag names are generally too long, I think. is completion-limit enough?