This is an archive of the discontinued LLVM Phabricator instance.

Differential D42463

[cmake] Set cmake policy CMP0068 to suppress warnings on OSX
ClosedPublic

Authored by hintonda on Jan 23 2018, 9:52 PM.

Details

Reviewers
beanz
compnerd
phosek
EricWF
Commits
rG32ff6599a81d: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX
rL323404: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX
Summary

Set cmake policy CMP0068=NEW, if available, and set
"CMAKE_BUILD_WITH_INSTALL_NAME_DIR=On" globally to
maintain current behavior.

This is needed to suppress warnings on OSX starting with cmake version
3.9.6.

Diff Detail

Event Timeline

hintonda created this revision.Jan 23 2018, 9:52 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptJan 23 2018, 9:52 PM
Harbormaster completed remote builds in B14178: Diff 131199.Jan 23 2018, 9:52 PM
hintonda added a child revision: D42490: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX.Jan 24 2018, 8:59 AM
phosek accepted this revision.Jan 24 2018, 9:08 AM

LGTM

This revision is now accepted and ready to land.Jan 24 2018, 9:08 AM
hintonda updated this revision to Diff 131316.Jan 24 2018, 11:03 AM

Set CMAKE_BUILD_WITH_INSTALL_NAME_DIR=ON globally so it can be used
for external projects.

Harbormaster completed remote builds in B14206: Diff 131316.Jan 24 2018, 11:03 AM
hintonda edited the summary of this revision. (Show Details)Jan 24 2018, 11:08 AM
hintonda added a comment.Jan 24 2018, 11:11 AM
In D42463#986629, @phosek wrote:

LGTM

I had to make a change since your LGTM, so please let me know if you'd like to take another look. Otherwise, I'll go ahead and land it tomorrow. Thanks again...

compnerd accepted this revision.Jan 24 2018, 6:02 PM

LGTM

Closed by commit rL323404: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX (authored by dhinton). · Explain WhyJan 24 2018, 8:58 PM
This revision was automatically updated to reflect the committed changes.
hintonda mentioned this in D42490: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX.Jan 31 2018, 5:36 PM
GitHub <noreply@github.com> mentioned this in rGc1ce21b450fd: cmake: allow disabling building with the install name directory .Oct 1 2023, 6:15 AM

Revision Contents

PathSize
5 lines

Diff 131316

CMakeLists.txt

Show All 11 Lines
# defer to the OLD behavior of not including generator expressions # defer to the OLD behavior of not including generator expressions
# in the output for now. # in the output for now.
cmake_policy(SET CMP0051 OLD) cmake_policy(SET CMP0051 OLD)
cmake_policy(SET CMP0056 NEW) cmake_policy(SET CMP0056 NEW)
cmake_policy(SET CMP0057 NEW) cmake_policy(SET CMP0057 NEW)
if(POLICY CMP0068)
cmake_policy(SET CMP0068 NEW)
set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
endif()
if(NOT DEFINED LLVM_VERSION_MAJOR) if(NOT DEFINED LLVM_VERSION_MAJOR)
set(LLVM_VERSION_MAJOR 7) set(LLVM_VERSION_MAJOR 7)
endif() endif()
if(NOT DEFINED LLVM_VERSION_MINOR) if(NOT DEFINED LLVM_VERSION_MINOR)
set(LLVM_VERSION_MINOR 0) set(LLVM_VERSION_MINOR 0)
endif() endif()
if(NOT DEFINED LLVM_VERSION_PATCH) if(NOT DEFINED LLVM_VERSION_PATCH)
set(LLVM_VERSION_PATCH 0) set(LLVM_VERSION_PATCH 0)
▲ Show 20 Lines • Show All 993 Lines • Show Last 20 Lines