This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Set cmake policy CMP0068 to suppress warnings on OSX
ClosedPublic

Authored by hintonda on Jan 23 2018, 9:52 PM.

Details

Summary

Set cmake policy CMP0068=NEW, if available, and set
"CMAKE_BUILD_WITH_INSTALL_NAME_DIR=On" globally to
maintain current behavior.

This is needed to suppress warnings on OSX starting with cmake version
3.9.6.

Diff Detail

Event Timeline

hintonda created this revision.Jan 23 2018, 9:52 PM
phosek accepted this revision.Jan 24 2018, 9:08 AM

LGTM

This revision is now accepted and ready to land.Jan 24 2018, 9:08 AM
hintonda updated this revision to Diff 131316.Jan 24 2018, 11:03 AM

Set CMAKE_BUILD_WITH_INSTALL_NAME_DIR=ON globally so it can be used
for external projects.

hintonda edited the summary of this revision. (Show Details)Jan 24 2018, 11:08 AM

LGTM

I had to make a change since your LGTM, so please let me know if you'd like to take another look. Otherwise, I'll go ahead and land it tomorrow. Thanks again...

This revision was automatically updated to reflect the committed changes.