Page MenuHomePhabricator

Issue local statics in correct DWARF lexical scope
Needs RevisionPublic

Authored by FlameTop on Jan 22 2018, 6:43 AM.

Details

Reviewers
JDevlieghere
rnk
Group Reviewers
debug-info
Summary

This is a matching change to an LLVM patch to ensure local statics are issued to the DWARF in the correct lexical scope.

This change detects the static being in a lexical block and ensures the debug into meta data is assigned to that scope.

A matching test will be added to debuginfo-tests.

Diff Detail

Event Timeline

FlameTop created this revision.Jan 22 2018, 6:43 AM
probinson added subscribers: cfe-commits, probinson.

+cfe-commits
See also the LLVM change in D42369 and a debuginfo-tests test in D42371.

JDevlieghere accepted this revision as: JDevlieghere.Sep 6 2018, 4:23 AM

This makes sense to me, LGTM.

This revision is now accepted and ready to land.Sep 6 2018, 4:23 AM
rnk requested changes to this revision.Sep 6 2018, 7:43 AM
rnk added a subscriber: rnk.

Still needs a test.

This revision now requires changes to proceed.Sep 6 2018, 7:43 AM

Just to clarify - the general philosophy (there are many cases of exceptions due to complications in various areas) is that clang changes should have clang tests (source code to IR), LLVM changes should have LLVM tests (IR to assembly or object code+dwarf dump) & if debuginfo-tests are optional/as-desired.