Page MenuHomePhabricator

FlameTop (Phil Camp)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2015, 6:14 AM (180 w, 3 d)

Recent Activity

Wed, May 8

FlameTop added a comment to D61089: [Reassociation] Place moved instructions after landing pads.

Looks like some lines got truncated from the head of the first test file. Test is failing due to no run line.

Wed, May 8, 9:30 AM · Restricted Project

Dec 21 2018

FlameTop added a comment to D55792: Allow direct navigation to static analysis checker documentation through SARIF exports.

I'm afraid we are seeing a build failure here on our local Windows checking MSVC build. Unfortunately I cannot find a public buildbot that uses the exact configuration that causes the assertion. The assertion we are seeing is

Dec 21 2018, 9:35 AM
FlameTop added inline comments to rL349812: Allow direct navigation to static analysis checker documentation through SARIF….
Dec 21 2018, 6:03 AM

Sep 13 2018

FlameTop added a comment to rL342088: [llvm-cov] Delete custom JSON serialization code (NFC).

May I ask if the changes made to 'binary-formats.canonical.json' in regards to making the filename checks more strict were deliberate? It is just that on Windows systems these checks now fail due to path name differences (the good old '/' vs '\' problems). I notice you did keep a more relaxed filename check intact in some other tests.

Sep 13 2018, 5:34 AM

Jan 23 2018

FlameTop added a comment to D42369: Issue local statics in correct DWARF lexical scope.

I'm not seeing where the add/getLocalLexicalDIEs APIs are being used.

Jan 23 2018, 5:23 AM
FlameTop updated the diff for D42369: Issue local statics in correct DWARF lexical scope.

Apologies, I had a lot of trouble getting svn setup on my machine. Seems I lost some changes in the original diff. Updated for code to issues the lexical DIEs.

Jan 23 2018, 5:19 AM

Jan 22 2018

FlameTop created D42370: Issue local statics in correct DWARF lexical scope.
Jan 22 2018, 6:44 AM
FlameTop created D42371: Issue local statics in correct DWARF lexical scope.
Jan 22 2018, 6:44 AM
FlameTop created D42369: Issue local statics in correct DWARF lexical scope.
Jan 22 2018, 6:44 AM

Oct 26 2017

FlameTop added a comment to D34272: [Tooling] A new framework for executing clang frontend actions..

Hello, I'm afraid this commit is failing on Windows.

Oct 26 2017, 5:34 AM

Oct 19 2017

FlameTop added a comment to D38030: Fix APFloat from string conversion for Inf.

I'm afraid this has broken Windows builds (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12860/steps/test/logs/stdio).

Oct 19 2017, 5:16 AM

Jun 19 2017

FlameTop added a comment to D34144: [CodeGen] Add generic MacroFusion pass..

This change is failing to build on windows buildbots.

Jun 19 2017, 4:34 AM

Jun 8 2017

FlameTop added inline comments to D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed..
Jun 8 2017, 5:36 AM · Restricted Project

Dec 20 2016

FlameTop abandoned D27410: Always issue vtables when generating coverage instrumentation.

I must apologise to you all. The problem was reported in our out-of-tree version of the compiler and I must have hit finger problems when I confirmed it in tree. Repeating the test I can no longer reproduce the fault with the 3.9.0 public build. It must be some effect of a local change.

Dec 20 2016, 8:11 AM

Dec 5 2016

FlameTop retitled D27410: Always issue vtables when generating coverage instrumentation from to Always issue vtables when generating coverage instrumentation.
Dec 5 2016, 6:00 AM

Nov 23 2016

FlameTop retitled D27043: Remove assertion on analysis of rvalue vector from to Remove assertion on analysis of rvalue vector.
Nov 23 2016, 6:19 AM

May 10 2016

FlameTop added a comment to D19866: [Analyzer] Correct stack address escape diagnostic.

Thank you for the acceptance.

May 10 2016, 7:16 AM

May 9 2016

FlameTop updated the diff for D19866: [Analyzer] Correct stack address escape diagnostic.

Thank you for your review. I have removed the changes to the bug description. Apologies, I did not realize it would alter the hash.

May 9 2016, 9:36 AM

May 3 2016

FlameTop retitled D19866: [Analyzer] Correct stack address escape diagnostic from to [Analyzer] Correct stack address escape diagnostic.
May 3 2016, 7:00 AM