This replaces an unordered_set from r322690 with an array and binary search.
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
- Build Status
Buildable 13936 Build 13936: arc lint + arc unit
Event Timeline
lib/Format/Format.cpp | ||
---|---|---|
1424–1425 | The ArrayRef doesn't own its contents, so this is a use-after-scope. I'd prefer static constexpr llvm::StringLiteral FoundationIdentifiers[] = { |
lib/Format/Format.cpp | ||
---|---|---|
1424–1425 | Should we add a comment that this array must be sorted if someone adds a new entry? |
The ArrayRef doesn't own its contents, so this is a use-after-scope.
I'd prefer static constexpr llvm::StringLiteral FoundationIdentifiers[] = {