Page MenuHomePhabricator

jolesiak (Jacek Olesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2017, 12:07 AM (86 w, 1 d)

Recent Activity

Feb 2 2019

jolesiak added a reverting change for D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver: rGf51ce777e3a6: Revert "[clang-format] Fix putting ObjC message arguments in one line for….
Feb 2 2019, 6:55 AM

Aug 20 2018

jolesiak added a comment to D50535: Fix selective formatting of ObjC scope.

Nice! That looks very promising.

Aug 20 2018, 10:25 AM

Aug 2 2018

jolesiak added a comment to D49580: [clang-format] Adding style option for absolute formatting.

Thanks!

Aug 2 2018, 12:30 AM

Jul 30 2018

jolesiak added a comment to D49580: [clang-format] Adding style option for absolute formatting.

Ok, so IIUC, understanding that @end effective ends a section much like "}" would address the currently observed problems?

Jul 30 2018, 3:09 AM
jolesiak added a comment to D49580: [clang-format] Adding style option for absolute formatting.

First of all, thanks, Arnaud, for looking into this.

Jul 30 2018, 2:57 AM

Jul 24 2018

jolesiak added a comment to D49580: [clang-format] Adding style option for absolute formatting.

Sorry for the delay, I'll comment on that tomorrow.

Jul 24 2018, 7:18 AM

Jul 10 2018

jolesiak added a comment to D44634: [clang-format] Detect Objective-C for #import <Foundation/Foundation.h>.

I think we should reconsider applying this change, at least for a very common "#import <Foundation/Foundation.h>".

Jul 10 2018, 11:14 PM
jolesiak closed D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.

This change was submitted (for some reason (probably some rebase operations) it was not automatically connected to the commit):
rC336521, rL336521.

Jul 10 2018, 10:46 PM
jolesiak closed D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.

This change was submitted (for some reason (probably some rebase operations) it was not automatically connected to the commit):
rC336520, rL336520

Jul 10 2018, 10:45 PM

Jul 9 2018

jolesiak committed rC336521: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
[clang-format/ObjC] Put ObjC method arguments into one line when they fit
Jul 9 2018, 12:13 AM
jolesiak committed rL336521: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
[clang-format/ObjC] Put ObjC method arguments into one line when they fit
Jul 9 2018, 12:13 AM

Jul 8 2018

jolesiak committed rL336520: [clang-format/ObjC] Improve split priorities for ObjC methods.
[clang-format/ObjC] Improve split priorities for ObjC methods
Jul 8 2018, 11:59 PM
jolesiak committed rC336520: [clang-format/ObjC] Improve split priorities for ObjC methods.
[clang-format/ObjC] Improve split priorities for ObjC methods
Jul 8 2018, 11:59 PM
jolesiak committed rL336519: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method….
[clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method…
Jul 8 2018, 11:10 PM
jolesiak committed rC336519: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method….
[clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method…
Jul 8 2018, 11:10 PM
jolesiak closed D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jul 8 2018, 11:09 PM
jolesiak committed rC336518: [clang-format/ObjC] Fix counting selector name parts for ObjC.
[clang-format/ObjC] Fix counting selector name parts for ObjC
Jul 8 2018, 11:06 PM
jolesiak committed rL336518: [clang-format/ObjC] Fix counting selector name parts for ObjC.
[clang-format/ObjC] Fix counting selector name parts for ObjC
Jul 8 2018, 11:04 PM
jolesiak closed D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.
Jul 8 2018, 11:03 PM

Jul 3 2018

jolesiak added a comment to D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.

Phabricator has an Edit Related Revisions feature where you can tag other revisions as being dependencies of or depending upon the current revision:

Jul 3 2018, 12:07 AM
jolesiak retitled D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit from [clang-format] Put ObjC method arguments into one line when they fit to [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
Jul 3 2018, 12:03 AM
jolesiak retitled D48719: [clang-format/ObjC] Improve split priorities for ObjC methods from [clang-format] Fix split priorities for ObjC methods to [clang-format/ObjC] Improve split priorities for ObjC methods.
Jul 3 2018, 12:02 AM
jolesiak updated the summary of D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jul 3 2018, 12:01 AM

Jul 2 2018

jolesiak retitled D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression from [clang-format] Prohibit breaking after a bracket opening ObjC method expression to [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jul 2 2018, 11:58 PM
jolesiak retitled D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC from [clang-format] Fix counting parameters/arguments for ObjC to [clang-format/ObjC] Fix counting selector name parts for ObjC.
Jul 2 2018, 11:56 PM
jolesiak added inline comments to D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
Jul 2 2018, 6:46 AM
jolesiak updated the diff for D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.

Rebase.

Jul 2 2018, 6:45 AM
jolesiak updated the diff for D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.

Improve condition.

Jul 2 2018, 6:44 AM
jolesiak added a comment to D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.

Can you add a test, please?

Jul 2 2018, 3:11 AM
jolesiak updated the diff for D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.

Fix grammar mistakes.

Jul 2 2018, 3:00 AM
jolesiak added a comment to D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.

Count selector parts also for method declarations.

What bug does this fix? Can you add a test which breaks before this change and is fixed by this change?

Jul 2 2018, 2:54 AM
jolesiak added inline comments to D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.
Jul 2 2018, 2:27 AM

Jun 28 2018

jolesiak abandoned D48352: [clang-format] Improve ObjC method expressions formatting.

Split:
D48716
D48718
D48719
D48720

Jun 28 2018, 6:42 AM
jolesiak updated the diff for D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.

Fix base change.

Jun 28 2018, 6:40 AM
jolesiak updated the diff for D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.

Fix comment.

Jun 28 2018, 6:36 AM
jolesiak updated the summary of D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
Jun 28 2018, 6:32 AM
jolesiak updated the summary of D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.
Jun 28 2018, 6:31 AM
jolesiak updated the summary of D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.
Jun 28 2018, 6:30 AM
jolesiak updated the summary of D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jun 28 2018, 6:29 AM
jolesiak updated the summary of D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.
Jun 28 2018, 6:28 AM
jolesiak created D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
Jun 28 2018, 6:20 AM
jolesiak created D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.
Jun 28 2018, 6:16 AM
jolesiak created D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jun 28 2018, 5:57 AM
jolesiak updated the diff for D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.

Fix comment

Jun 28 2018, 5:41 AM
jolesiak created D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.
Jun 28 2018, 5:36 AM

Jun 27 2018

jolesiak added a comment to D48352: [clang-format] Improve ObjC method expressions formatting.

It's really hard to understand reviews which change 4 different things.

I hate to ask, but can you split this up into the 4 fixes?

Jun 27 2018, 9:39 AM

Jun 22 2018

jolesiak committed rL335338: [clang-format] Add AlwaysBreakBeforeMultilineString tests.
[clang-format] Add AlwaysBreakBeforeMultilineString tests
Jun 22 2018, 5:02 AM
jolesiak committed rC335338: [clang-format] Add AlwaysBreakBeforeMultilineString tests.
[clang-format] Add AlwaysBreakBeforeMultilineString tests
Jun 22 2018, 5:02 AM
jolesiak closed D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests.
Jun 22 2018, 5:02 AM

Jun 21 2018

jolesiak updated the summary of D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests.
Jun 21 2018, 7:46 AM
jolesiak added a reviewer for D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests: stephanemoore.
Jun 21 2018, 7:46 AM
jolesiak created D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests.
Jun 21 2018, 7:45 AM

Jun 20 2018

jolesiak added a reviewer for D48352: [clang-format] Improve ObjC method expressions formatting: klimek.
Jun 20 2018, 3:28 AM
jolesiak updated the summary of D48352: [clang-format] Improve ObjC method expressions formatting.
Jun 20 2018, 2:52 AM
jolesiak updated the diff for D48352: [clang-format] Improve ObjC method expressions formatting.
  • Add test
Jun 20 2018, 2:48 AM
jolesiak created D48352: [clang-format] Improve ObjC method expressions formatting.
Jun 20 2018, 2:28 AM

Jun 14 2018

jolesiak added a comment to D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜.

Sorry, I missed that.
LGTM, I would consider adding ObjC method expression tests (multiline string as an argument). Will look into that next week.

Jun 14 2018, 6:03 PM

May 30 2018

jolesiak committed rL333539: Revert "[clang-format] Fix putting ObjC message arguments in one line for….
Revert "[clang-format] Fix putting ObjC message arguments in one line for…
May 30 2018, 6:02 AM
jolesiak committed rC333539: Revert "[clang-format] Fix putting ObjC message arguments in one line for….
Revert "[clang-format] Fix putting ObjC message arguments in one line for…
May 30 2018, 6:02 AM
jolesiak closed D47527: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 30 2018, 6:02 AM
jolesiak updated the summary of D47527: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 30 2018, 3:41 AM
jolesiak updated the summary of D47527: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 30 2018, 3:36 AM
jolesiak created D47527: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 30 2018, 3:10 AM

May 24 2018

jolesiak committed rC333171: [clang-format] Fix putting ObjC message arguments in one line for multiline….
[clang-format] Fix putting ObjC message arguments in one line for multiline…
May 24 2018, 3:54 AM
jolesiak committed rL333171: [clang-format] Fix putting ObjC message arguments in one line for multiline….
[clang-format] Fix putting ObjC message arguments in one line for multiline…
May 24 2018, 3:54 AM
jolesiak closed D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 24 2018, 3:54 AM
jolesiak added a comment to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.

Does it look fine now @krasimir ?

May 24 2018, 1:04 AM
jolesiak accepted D47095: [clang-format/ObjC] Correctly parse Objective-C methods with 'class' in name.
May 24 2018, 12:48 AM
jolesiak added a comment to D47095: [clang-format/ObjC] Correctly parse Objective-C methods with 'class' in name.

LGTM, would be nice though if somebody else took a look (@klimek ?).

May 24 2018, 12:48 AM

May 23 2018

jolesiak added inline comments to D47095: [clang-format/ObjC] Correctly parse Objective-C methods with 'class' in name.
May 23 2018, 4:42 AM
jolesiak added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 23 2018, 1:06 AM
jolesiak updated the diff for D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
  • Add test
May 23 2018, 1:05 AM

May 22 2018

jolesiak retitled D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver from [clang-format] Fix ObjC message arguments handling to [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 10:11 AM
jolesiak updated the diff for D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.

Rebase.

May 22 2018, 10:05 AM
jolesiak committed rL332998: Revert "[clang-format] Fix putting ObjC message arguments in one line for….
Revert "[clang-format] Fix putting ObjC message arguments in one line for…
May 22 2018, 9:48 AM
jolesiak committed rC332998: Revert "[clang-format] Fix putting ObjC message arguments in one line for….
Revert "[clang-format] Fix putting ObjC message arguments in one line for…
May 22 2018, 9:48 AM
jolesiak closed D47205: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 22 2018, 9:48 AM
jolesiak added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 9:44 AM
jolesiak updated the summary of D47205: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 22 2018, 9:42 AM
jolesiak created D47205: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 22 2018, 9:41 AM
jolesiak added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 8:50 AM
jolesiak added reviewers for D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver: benhamilton, djasper, krasimir.
May 22 2018, 6:26 AM
jolesiak updated the summary of D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 6:24 AM
jolesiak created D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 6:19 AM

May 18 2018

jolesiak accepted D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations.
May 18 2018, 7:28 AM

May 17 2018

jolesiak committed rL332582: [clang-format] Fix putting ObjC message arguments in one line for multiline….
[clang-format] Fix putting ObjC message arguments in one line for multiline…
May 17 2018, 1:39 AM
jolesiak committed rC332582: [clang-format] Fix putting ObjC message arguments in one line for multiline….
[clang-format] Fix putting ObjC message arguments in one line for multiline…
May 17 2018, 1:39 AM
jolesiak closed D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 17 2018, 1:39 AM
jolesiak closed D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 17 2018, 1:39 AM

May 15 2018

jolesiak added reviewers for D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver: benhamilton, djasper.
May 15 2018, 7:16 AM
jolesiak updated the summary of D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 15 2018, 7:12 AM
jolesiak updated the summary of D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 15 2018, 7:11 AM
jolesiak created D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 15 2018, 7:11 AM

Apr 5 2018

jolesiak added a comment to D45004: [clang-format] Always indent wrapped Objective-C selector names.

I am proposing to update the Google Objective-C style guide to explicitly describe the desired indentation behavior.

Apr 5 2018, 1:11 AM

Apr 4 2018

jolesiak accepted D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly.

lgtm

Apr 4 2018, 8:46 AM

Mar 29 2018

jolesiak added inline comments to D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly.
Mar 29 2018, 1:30 AM
jolesiak added inline comments to D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly.
Mar 29 2018, 1:21 AM
jolesiak added inline comments to D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly.
Mar 29 2018, 12:59 AM
jolesiak accepted D44994: [clang-format] Ensure wrapped ObjC selectors with 1 arg obey IndentWrappedFunctionNames.

Well spotted.

Mar 29 2018, 12:02 AM

Mar 21 2018

jolesiak accepted D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl.
Mar 21 2018, 5:24 AM