Makes sense, thanks for patching this!

Nice! That looks very promising.

Thanks!

In D49580#1179924, @djasper wrote:

Ok, so IIUC, understanding that @end effective ends a section much like "}" would address the currently observed problems?

First of all, thanks, Arnaud, for looking into this.

Sorry for the delay, I'll comment on that tomorrow.

I think we should reconsider applying this change, at least for a very common "#import <Foundation/Foundation.h>".

This change was submitted (for some reason (probably some rebase operations) it was not automatically connected to the commit):
rC336521, rL336521.

This change was submitted (for some reason (probably some rebase operations) it was not automatically connected to the commit):
rC336520, rL336520

In D48716#1149733, @benhamilton wrote:

Phabricator has an Edit Related Revisions feature where you can tag other revisions as being dependencies of or depending upon the current revision:

Rebase.

Improve condition.

In D48718#1146805, @benhamilton wrote:

Can you add a test, please?

Fix grammar mistakes.

In D48716#1146796, @benhamilton wrote:

Count selector parts also for method declarations.

What bug does this fix? Can you add a test which breaks before this change and is fixed by this change?

Split:
D48716
D48718
D48719
D48720

Fix base change.

Fix comment.

Fix comment

In D48352#1145220, @benhamilton wrote:

It's really hard to understand reviews which change 4 different things.

I hate to ask, but can you split this up into the 4 fixes?

• Add test

Sorry, I missed that.
LGTM, I would consider adding ObjC method expression tests (multiline string as an argument). Will look into that next week.

Does it look fine now @krasimir ?

LGTM, would be nice though if somebody else took a look (@klimek ?).

• Add test

Rebase.

I am proposing to update the Google Objective-C style guide to explicitly describe the desired indentation behavior.

lgtm

Well spotted.