See bug 35764: https://bugs.llvm.org/show_bug.cgi?id=35764
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | Shouldn't this be xnack enabled (or at least >= VI) |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | Thanks, Matt! I'll correct that shortly. |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | I am not sure. https://github.com/ROCm-Developer-Tools/ROCm-ComputeABI-Doc/blob/master/AMDGPU-ABI.md#instruction-set-architecture says: |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | I suppose for encoding/decoding purposes, I suppose it won't make a difference, it will just produce an unusable program for the target. Maybe a warning? |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | We have a FeatureXNACK, but it is enabled only for 8_0_1 and 8_1_0. And not for any of GFX9 targets. So I do not think we could use that. Is the feature list for GFX9 incomplete? |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | Do you know which GFX9 targets support this feature? |
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
2607 ↗ | (On Diff #128282) | + @t-tye I think this should check the FeatureXNACK (and maybe >=VI, xnack started from VI). Users can pass -mxnack, -mno-xnack regardless the target from clang, which will set FeatureXNACK to true or false respectively. Runtime has to ensure it is valid. |
Corrected XNACK availability check as suggested by Matt and Konstantin; updated tests.