Details
Diff Detail
Event Timeline
llvm/lib/Support/Host.cpp | ||
---|---|---|
222 | Can you initialize Exynos to some value here? | |
233–234 | How about if (I.consume_front("CPU part")) I.ltrim("\t :").getAsInteger(16, Part); As an example of why I prefer consume_front, it fixes what appears to be above in the preceding if statement (about CPU variant), where you've hardcoded 8 but actually meant 11. | |
236 | Can you move the declaration of Exynos down here and just say: unsigned Exynos = (Variant << 12) + Part; That also simultaneously addresses my previous comment about initialization. |
llvm/lib/Support/Host.cpp | ||
---|---|---|
233–234 | Makes sense. |
LGTM modulo the one nitpick for which I'm not sure if it is needed.
llvm/lib/Support/Host.cpp | ||
---|---|---|
237–241 | I guess you may need to use LLVM_FALLTHROUGH here to silence a warning with some compilers? |
Can you initialize Exynos to some value here?