This is an archive of the discontinued LLVM Phabricator instance.

Differential D40717

Makefile.rules: compile all tests with -fno-limit-debug-info
ClosedPublic

Authored by labath on Dec 1 2017, 5:22 AM.

Details

Reviewers
davide
jankratochvil
Commits
rGfd9a526a30cd: Makefile.rules: compile all tests with -fno-limit-debug-info
rLLDB319653: Makefile.rules: compile all tests with -fno-limit-debug-info
rL319653: Makefile.rules: compile all tests with -fno-limit-debug-info
Summary

This flag is on by default for darwin and freebsd, but off for linux.
Without it, clang will sometimes not emit debug info for types like
std::string. Whether it does this, and which tests will fail because of
that depends on the linux distro and c++ library version.

A bunch of tests were already setting these flags manually, but here
instead I take a whole sale approach and enable this flag for all tests.
Any test which does not want to have this flag (right now we have one
such test) can turn it off explicitly via
CFLAGS_EXTRAS+=$(LIMIT_DEBUG_INFO_FLAGS)

Can you check whether this makes any difference for test results on
red-hat?

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Dec 1 2017, 5:22 AM
Harbormaster completed remote builds in B12670: Diff 125114.Dec 1 2017, 5:22 AM
Herald added subscribers: JDevlieghere, krytarowski, aprantl, emaste. · View Herald TranscriptDec 1 2017, 5:22 AM
jankratochvil accepted this revision.Dec 1 2017, 7:06 AM

On Fedora 27 x86_64 it has no regressions and these results turned Failure->Success:

LibcxxIteratorDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxIteratorDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxIteratorDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxListDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxListDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMapDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMapDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMapDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxSetDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxSetDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxSetDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxStringDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxStringDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxStringDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_gmodules.log
TestDataFormatterLibcxxTuple-test_dwarf.log
TestDataFormatterLibcxxTuple-test_dwo.log
TestDataFormatterLibcxxTuple-test_gmodules.log
ThreadStateTestCase-test_process_interrupt_gmodules.log

Test ThreadStateTestCase-test_process_interrupt_gmodules.log turned ExpectedFailure->ExpectedSuccess.
Full results: D40717.tar.xz
Thanks.

This revision is now accepted and ready to land.Dec 1 2017, 7:06 AM
Closed by commit rL319653: Makefile.rules: compile all tests with -fno-limit-debug-info (authored by labath). · Explain WhyDec 4 2017, 5:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
packages/
Python/
lldbsuite/
test/
expression_command/
anonymous-struct/
7 lines
call-function/
7 lines
fixits/
7 lines
functionalities/
data-formatter/
data-formatter-skip-summary/
7 lines
data-formatter-stl/
libstdcpp/
iterator/
7 lines
list/
7 lines
map/
7 lines
smart_ptr/
7 lines
string/
7 lines
tuple/
1 line
unique_ptr/
1 line
vector/
7 lines
data-formatter-synth/
7 lines
dump_dynamic/
7 lines
stringprinter/
7 lines
summary-string-onfail/
7 lines
var-in-aggregate-misuse/
6 lines
type_completion/
7 lines
lang/
cpp/
auto/
2 lines
stl/
7 lines
template/
2 lines
make/
3 lines
python_api/
sbvalue_persist/
7 lines

Diff 125313

lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
clean:: clean::
rm -rf $(wildcard *.o *.d *.dSYM) rm -rf $(wildcard *.o *.d *.dSYM)

lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 0 USE_LIBSTDCPP := 0
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
CXXFLAGS += -O0 CXXFLAGS += -O0

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS += -O0 CFLAGS_EXTRAS += -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS += -O0 CFLAGS_EXTRAS += -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS := -O0 CXXFLAGS := -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS += -O0 CFLAGS_EXTRAS += -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS := -O0 CXXFLAGS := -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS += -std=c++11 CXXFLAGS += -std=c++11
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS += -std=c++11 CXXFLAGS += -std=c++11
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# Workaround for llvm.org/pr16214: clang doesn't emit structure definition DWARF
# information without the flag below.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS := -g -O0 CFLAGS := -g -O0
clean: OBJECTS+=$(wildcard main.d.*) clean: OBJECTS+=$(wildcard main.d.*)
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines
CFLAGS ?= $(DEBUG_INFO_FLAG) -O0 -fno-builtin CFLAGS ?= $(DEBUG_INFO_FLAG) -O0 -fno-builtin
ifeq "$(OS)" "Darwin" ifeq "$(OS)" "Darwin"
CFLAGS += $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) -I$(LLDB_BASE_DIR)include CFLAGS += $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) -I$(LLDB_BASE_DIR)include
else else
CFLAGS += $(ARCHFLAG)$(ARCH) $(FRAMEWORK_INCLUDES) -I$(LLDB_BASE_DIR)include CFLAGS += $(ARCHFLAG)$(ARCH) $(FRAMEWORK_INCLUDES) -I$(LLDB_BASE_DIR)include
endif endif
CFLAGS += -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS) CFLAGS += -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR)
CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS)
# Use this one if you want to build one part of the result without debug information: # Use this one if you want to build one part of the result without debug information:
ifeq "$(OS)" "Darwin" ifeq "$(OS)" "Darwin"
CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS) CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS)
else else
CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG)$(ARCH) $(FRAMEWORK_INCLUDES) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS) CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG)$(ARCH) $(FRAMEWORK_INCLUDES) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS)
endif endif
▲ Show 20 Lines • Show All 439 Lines • Show Last 20 Lines

lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# Clean renamed executable on 'make clean' # Clean renamed executable on 'make clean'
clean: OBJECTS+=no_synth clean: OBJECTS+=no_synth
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules