Page MenuHomePhabricator

Makefile.rules: compile all tests with -fno-limit-debug-info
ClosedPublic

Authored by labath on Dec 1 2017, 5:22 AM.

Details

Summary

This flag is on by default for darwin and freebsd, but off for linux.
Without it, clang will sometimes not emit debug info for types like
std::string. Whether it does this, and which tests will fail because of
that depends on the linux distro and c++ library version.

A bunch of tests were already setting these flags manually, but here
instead I take a whole sale approach and enable this flag for all tests.
Any test which does not want to have this flag (right now we have one
such test) can turn it off explicitly via
CFLAGS_EXTRAS+=$(LIMIT_DEBUG_INFO_FLAGS)

Can you check whether this makes any difference for test results on
red-hat?

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Dec 1 2017, 5:22 AM
jankratochvil accepted this revision.Dec 1 2017, 7:06 AM

On Fedora 27 x86_64 it has no regressions and these results turned Failure->Success:

LibcxxIteratorDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxIteratorDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxIteratorDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxListDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxListDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMapDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMapDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMapDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMultiMapDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxMultiSetDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxSetDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxSetDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxSetDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxStringDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxStringDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxStringDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxUnorderedDataFormatterTestCase-test_with_run_command_gmodules.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_dwarf.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_dwo.log
LibcxxVectorDataFormatterTestCase-test_with_run_command_gmodules.log
TestDataFormatterLibcxxTuple-test_dwarf.log
TestDataFormatterLibcxxTuple-test_dwo.log
TestDataFormatterLibcxxTuple-test_gmodules.log
ThreadStateTestCase-test_process_interrupt_gmodules.log

Test ThreadStateTestCase-test_process_interrupt_gmodules.log turned ExpectedFailure->ExpectedSuccess.
Full results: D40717.tar.xz
Thanks.

This revision is now accepted and ready to land.Dec 1 2017, 7:06 AM
This revision was automatically updated to reflect the committed changes.