This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Use SEH exception handling on MS
ClosedPublic

Authored by martell on Nov 21 2017, 12:23 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

martell created this revision.Nov 21 2017, 12:23 AM
martell retitled this revision from [ARM] Use dwarf exception handling on MS to [ARM] Use SEH exception handling on MS.Nov 21 2017, 12:24 AM
martell added a reviewer: compnerd.
martell edited the summary of this revision. (Show Details)
mstorsjo edited edge metadata.Nov 21 2017, 1:14 AM

I remember @compnerd saying that the SEH/ARM was documented but not actually really implemented yet: https://reviews.llvm.org/D39532#914461

I remember @compnerd saying that the SEH/ARM was documented but not actually really implemented yet: https://reviews.llvm.org/D39532#914461

Is SEH implemented for aarch64 because if not then I would prefer setting SEH here like we do for aarch64?

Is SEH implemented for aarch64 because if not then I would prefer setting SEH here like we do for aarch64?

No, it isn't. So if you try to compile code in msvc mode that uses exceptions, it'll fail due to unimplemented codepaths. It was set/enabled on aarch64 as a side effect in SVN r308665 (git mirror commit 8c714df517f9a42f5b360b2a2ca619facd961b40).

But consistency obviously is nice, and this is what would need to be implemented for exceptions for msvc mode for arm in any case, so I don't mind setting it - the failures make it much clearer that the exceptions actually don't work yet.

This revision was automatically updated to reflect the committed changes.