This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Avoid unnecessarily hiding inline visibility [NFC]
ClosedPublic

Authored by nikhgupt on Nov 20 2017, 1:50 PM.

Download Raw Diff

Details

Reviewers

cryptoad
weimingz
mgorny
vsk
compnerd
peter.smith
nikhgupt

Commits

rGe4ba19efdc84: [compiler-rt] Avoid unnecessarily hiding inline visibility [NFC]
rCRT319257: [compiler-rt] Avoid unnecessarily hiding inline visibility [NFC]
rL319257: [compiler-rt] Avoid unnecessarily hiding inline visibility [NFC]

Summary

having fvisibility=hidden obviates the need for
fvisibility-inlines-hidden.

Diff Detail

Repository: rL LLVM

Event Timeline

nikhgupt created this revision.Nov 20 2017, 1:50 PM

Harbormaster completed remote builds in B12339: Diff 123652.Nov 20 2017, 1:50 PM

Herald added subscribers: mgorny, dberris. · View Herald TranscriptNov 20 2017, 1:50 PM

nikhgupt retitled this revision from [compiler-rt] Make inline visibility on fvisibility to [compiler-rt] Make inline visibility on fvisibility [NFC].Nov 20 2017, 1:56 PM

nikhgupt added reviewers: cryptoad, weimingz, mgorny, vsk.Nov 20 2017, 2:00 PM

LGTM. Adding Saleem and Peter for confirming.

Hold on. Why do we need this flag? There is no c++ code in builtins.

In D40269#930857, @weimingz wrote:

Hold on. Why do we need this flag? There is no c++ code in builtins.

Sorry. Never mind. I thought it's for builtin.

I don't have any objections.

This change is helpful for portability.

nikhgupt accepted this revision.Nov 27 2017, 9:10 AM

This revision is now accepted and ready to land.Nov 27 2017, 9:10 AM

Nit: could you make the commit title a bit clearer? Apart from that, this lgtm.

nikhgupt retitled this revision from [compiler-rt] Make inline visibility on fvisibility [NFC] to [compiler-rt] Avoid unnecessarily hiding inline visibility [NFC].Nov 27 2017, 10:44 AM

Closed by commit rL319257: [compiler-rt] Avoid unnecessarily hiding inline visibility [NFC] (authored by weimingz). · Explain WhyNov 28 2017, 3:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

CMakeLists.txt

4 lines

Diff 124656

compiler-rt/trunk/CMakeLists.txt

	Show First 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
	append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS)
	if(NOT COMPILER_RT_DEBUG AND NOT APPLE)			if(NOT COMPILER_RT_DEBUG AND NOT APPLE)
	append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)
	endif()			endif()
	append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS)
	append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS)
	append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)
	append_list_if(COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS)
				if(NOT COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG)
	append_list_if(COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG -fvisibility-inlines-hidden SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG -fvisibility-inlines-hidden SANITIZER_COMMON_CFLAGS)
				endif()
	append_list_if(COMPILER_RT_HAS_FNO_LTO_FLAG -fno-lto SANITIZER_COMMON_CFLAGS)			append_list_if(COMPILER_RT_HAS_FNO_LTO_FLAG -fno-lto SANITIZER_COMMON_CFLAGS)

	# The following is a workaround for powerpc64le. This is the only architecture			# The following is a workaround for powerpc64le. This is the only architecture
	# that requires -fno-function-sections to work properly. If lacking, the ASan			# that requires -fno-function-sections to work properly. If lacking, the ASan
	# Linux test function-sections-are-bad.cc fails with the following error:			# Linux test function-sections-are-bad.cc fails with the following error:
	# 'undefined symbol: __sanitizer_unaligned_load32'.			# 'undefined symbol: __sanitizer_unaligned_load32'.
	if(DEFINED TARGET_powerpc64le_CFLAGS)			if(DEFINED TARGET_powerpc64le_CFLAGS)
	append_list_if(COMPILER_RT_HAS_FNO_FUNCTION_SECTIONS_FLAG -fno-function-sections TARGET_powerpc64le_CFLAGS)			append_list_if(COMPILER_RT_HAS_FNO_FUNCTION_SECTIONS_FLAG -fno-function-sections TARGET_powerpc64le_CFLAGS)
	▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines