Page MenuHomePhabricator

[AArch64] Refactor the loads and stores optimizer
ClosedPublic

Authored by evandro on Nov 15 2017, 9:49 AM.

Details

Summary

Move remaining inline matching of instructions of some optimizations into separate functions, like in the other optimizations. Otherwise, NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

evandro created this revision.Nov 15 2017, 9:49 AM
This revision is now accepted and ready to land.Nov 15 2017, 10:43 AM
fhahn accepted this revision.Nov 15 2017, 10:47 AM

LGTM

llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
585 ↗(On Diff #123047)

Nit: should this be at the previous line?

evandro marked an inline comment as done.Nov 15 2017, 10:59 AM
evandro added inline comments.
llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
585 ↗(On Diff #123047)

:-}

junbuml added inline comments.Nov 15 2017, 11:00 AM
llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
1646–1647 ↗(On Diff #123047)

Please keep this comment.

junbuml added inline comments.Nov 15 2017, 11:06 AM
llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
1646–1647 ↗(On Diff #123047)

Sorry. it doesn't seem so really needed now.

mcrosier accepted this revision.Nov 15 2017, 11:40 AM

Please run clang-format, but otherwise LGTM.

This revision was automatically updated to reflect the committed changes.
evandro marked an inline comment as done.