Details
Diff Detail
- Build Status
Buildable 11460 Build 11460: arc lint + arc unit
Event Timeline
llvm/lib/Object/ELF.cpp | ||
---|---|---|
478 | It is probably worth to mention briefly as a function comment that this function reads relocations represented as ULEB128 values, which is a compact relocation format invented for Android. | |
492 | nit: I believe you can omit () | |
527 | Can this RHS expression return a negative value? If not, Addend is a monotonically increasing, which is odd. | |
550 | I'd add a check to make sure that NumRelocs is not negative. |
It is probably worth to mention briefly as a function comment that this function reads relocations represented as ULEB128 values, which is a compact relocation format invented for Android.