This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Implement omp_is_initial_device() as builtin
ClosedPublic

Authored by Hahnfeld on Oct 16 2017, 11:59 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld created this revision.Oct 16 2017, 11:59 AM
This revision is now accepted and ready to land.Oct 16 2017, 12:21 PM
grokos edited edge metadata.Oct 16 2017, 1:40 PM

Now that this issue has been addressed and regressions tests pass, should we re-enable Cmake to build libomptarget by default?

Now that this issue has been addressed and regressions tests pass, should we re-enable Cmake to build libomptarget by default?

Yes, I already have a local patch which also takes care of restricting the tests to Clang versions newer than 6.0.0. I will post it for review once I've committed this revision.

This revision was automatically updated to reflect the committed changes.

@jdoerfert suggested replacing this with a context selector. One less special case in clang.

Related, if this is a builtin (or in header), I think we can and should delete it from the devicertl. It's probably used as a branch condition so replacing with a 0/1 asap is winning for compilation time.