This is an update to D5767, adding the missing tests.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Please make sure patches get sent to cfe-commits in addition to the reviewers, as per https://llvm.org/docs/Phabricator.html
Comment Actions
Thank you! Please move the tests to a new subdirectory under test, say test/Templight.
tools/CMakeLists.txt | ||
---|---|---|
37 โ | (On Diff #118676) | Did you mean to include this in this patch? There's no such directory added here. (Should this be an add_llvm_external_project, to pick up some external project if it's checked out here?) |
Comment Actions
I have moved the tests into their own directory in the last update.
tools/CMakeLists.txt | ||
---|---|---|
37 โ | (On Diff #118676) | It is a reference to a utility based on this patch. The utility has not been finished yet, so I have removed that line. |
Comment Actions
The last update of the patch also contains the changes to this pull request based on comments from D5767.