This is an archive of the discontinued LLVM Phabricator instance.

Move the stripping of malformed debug info from the Verifier to AutoUpgrade.

Authored by aprantl on Sep 22 2017, 11:15 AM.



This came out of a recent discussion on llvm-dev
( Currently the Verifier will strip
the debug info metadata from a module if it finds the dbeug info to be
malformed. This feature is very valuable since it allows us to improve
the Verifier by making it stricter without breaking backwards compatibility,
but arguable the Verifier pass should not be modifying the IR.

This patch moves the stripping of broken debug info into AutoUpgrade
(UpgradeDebugInfo to be precise), which is a much better location for
this since the stripping of malformed (i.e., produced by older, buggy
versions of Clang) is a (harsh) form of AutoUpgrade.

This change is mostly NFCish in nature, the one big difference is the
behavior when LLVM module passes are introducing malformed debug
info. Prior to this patch, a NoAsserts build would have printed a
warning and stripped the debug info and an Asserts build would have
asserted, after this patch the Verifier will report a fatal error.
I believe that the new behavior is actually more desirable anyway.

Diff Detail


Event Timeline

aprantl created this revision.Sep 22 2017, 11:15 AM
rnk added a subscriber: rnk.Oct 2 2017, 9:14 AM
rnk added inline comments.
39–40 ↗(On Diff #116376)

Maybe make the parameter UpgradeDebugInfo = true and indicate that debug info upgrading requires verified IR?

aprantl updated this revision to Diff 117375.Oct 2 2017, 9:49 AM

Address review feedback from @rnk, thanks!

rnk accepted this revision.Oct 2 2017, 10:39 AM


This revision is now accepted and ready to land.Oct 2 2017, 10:39 AM
This revision was automatically updated to reflect the committed changes.