[analyzer] PthreadLock: Refactor, use PostCall API. NFC.
Needs ReviewPublic

Authored by NoQ on Wed, Sep 13, 7:04 AM.

Details

Summary

Use CallEvent and CallDescription everywhere. Unhardcode argument numbers in AcquireLock() etc. Have a list of supported functions in one place. Other misc cleanup. No functional change intended anywhere.

Diff Detail

NoQ created this revision.Wed, Sep 13, 7:04 AM
NoQ updated this revision to Diff 115042.Wed, Sep 13, 7:19 AM

Don't forget to check that the function is a global C function in post-call.

How about committing the refactor of the code without test modifications. And committing changes to the test separately?

NoQ updated this revision to Diff 115586.Sun, Sep 17, 1:02 PM

Remove the changes in tests for now. I guess they'd need more cleanup anyway.