lck_mtx_lock() returns void. The analyzer failed to model its effect because he was surprised that the return value is Unknown. Prepare for the aforementioned surprise and fix the tests accordingly.
|271 ↗||(On Diff #115029)|
Because it is relevant in both places. Should i rephrase with "also"/"as well"/"here too"?
|29 ↗||(On Diff #115029)|
The tests are already there for all three functions. I just fixed their prototype to match the real-world prototype, and then adjusted the code accordingly, so that the existing tests kept passing.
Sorry for long delay for reviews. Unfortunately, hospital is a bad place to do a code review and broken hand is a bad review assistant. This patch looks good to me, I have just a minor comment nit.
|282 ↗||(On Diff #115029)|