This is an archive of the discontinued LLVM Phabricator instance.

Differential D37302

[Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
ClosedPublic

Authored by pirama on Aug 30 2017, 10:15 AM.

Details

Reviewers
bruno
rsmith
doug.gregor
ldionne
Commits
rG3c1a7bc290fb: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
rL339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
Summary

These macros are defined in the C11 standard and can be defined based on
the *_HAS_DENORM default macros.

Diff Detail

Repository
rC Clang

Event Timeline

pirama created this revision.Aug 30 2017, 10:15 AM
pirama added a comment.Aug 30 2017, 10:20 AM

It looks like all architectures that Clang supports have denorm support. AFAICT, none of them have the "indeterminable" behavior. So it seems safe to define these macros here.

@bruno The test lib/Headers/darwin.c will now pass even if the include_next for Darwin fails. If there are more definitions in the Darwin float.h, I can update to test that definition instead of FLT_HAS_SUBNORM.

efriedma added a subscriber: cfe-commits.Aug 30 2017, 11:44 AM
pirama added a comment.Sep 6 2017, 9:21 AM

Ping...

pirama added a comment.Sep 13 2017, 4:33 PM

Ping....

rsmith accepted this revision.Sep 13 2017, 5:35 PM

LGTM

This revision is now accepted and ready to land.Sep 13 2017, 5:35 PM
pirama added a comment.Sep 14 2017, 3:34 PM

@bruno Any suggestion on how to update test/Headers/float-darwin,c* so make it check the include_next? I am unable to find the darwin-specific float.h inside an XCode installation directory.

  • Oops, my earlier comment had the wrong test name
joerg added a subscriber: joerg.Sep 15 2017, 1:39 AM

So what about targets that don't support subnormals? I'm moderately sure ARM falls into this category given the right phase of the moon.

pirama added a comment.Sep 15 2017, 10:11 AM
In D37302#871794, @joerg wrote:

So what about targets that don't support subnormals? I'm moderately sure ARM falls into this category given the right phase of the moon.

Clang defines __FLT_HAS_DENORM__ and friends unconditionally, so I thought we could do this for FLT_HAS_SUBNORM as well, considering that gcc did the same. But that might be misleading because gcc's float.h was just for the target of that particular gcc build.

Am I right to understand that __FLT_HAS_DENORM__ signifies *compiler* support for denorms as opposed to support on the *platforms* supported? If so, it might support our alternative consideration of defining these macros in the bionic/libc headers for Android (and rely on the include_next similar to Windows and Darwin).

pirama updated this revision to Diff 124313.Nov 26 2017, 2:07 PM
  • Switch kryo to use -mcpu=cortex-a57 when invoking the assembler
Harbormaster completed remote builds in B12474: Diff 124313.Nov 26 2017, 2:08 PM
pirama updated this revision to Diff 124314.Nov 26 2017, 2:11 PM

Revert to previous patch after accidental update

pirama updated this revision to Diff 124315.Nov 26 2017, 2:12 PM

Actually revert

Harbormaster completed remote builds in B12475: Diff 124314.Nov 26 2017, 2:12 PM
Harbormaster completed remote builds in B12476: Diff 124315.
pirama updated this revision to Diff 139666.Mar 23 2018, 4:27 PM
  • [CodeGen] Mark fma as const for Android
Harbormaster completed remote builds in B16405: Diff 139666.Mar 23 2018, 4:27 PM
pirama updated this revision to Diff 139667.Mar 23 2018, 4:28 PM
  • [CodeGen] Mark fma as const for Android
pirama updated this revision to Diff 139670.Mar 23 2018, 4:30 PM

Remove unexpected change from another patch.

Harbormaster completed remote builds in B16406: Diff 139667.Mar 23 2018, 4:31 PM
Harbormaster completed remote builds in B16408: Diff 139670.
ldionne accepted this revision.Aug 3 2018, 3:34 PM
ldionne added a subscriber: ldionne.

What are we waiting for to move forward with this change?

pirama updated this revision to Diff 159330.Aug 6 2018, 10:12 AM

Rebase

Harbormaster completed remote builds in B21122: Diff 159330.Aug 6 2018, 10:12 AM
pirama added a comment.Aug 6 2018, 10:14 AM

Sorry this fell of my radar. I've rebased the patch.

Since this has been inactive for a while, lets wait for a couple of days to see if there are any other comments. If there are no objections, I'll submit this on Wednesday.

ldionne added a comment.Aug 6 2018, 10:15 AM
In D37302#1189576, @pirama wrote:

Sorry this fell of my radar. I've rebased the patch.

Since this has been inactive for a while, lets wait for a couple of days to see if there are any other comments. If there are no objections, I'll submit this on Wednesday.

Ok. FWIW, I was about to submit exactly the same patch when I found yours. This solves a problem for me.

Closed by commit rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL (authored by pirama). · Explain WhyAug 8 2018, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Headers/
6 lines
test/
Headers/
24 lines

Diff 159778

lib/Headers/float.h

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
# undef LDBL_MIN # undef LDBL_MIN
# if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) # if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__)
# undef FLT_TRUE_MIN # undef FLT_TRUE_MIN
# undef DBL_TRUE_MIN # undef DBL_TRUE_MIN
# undef LDBL_TRUE_MIN # undef LDBL_TRUE_MIN
# undef FLT_DECIMAL_DIG # undef FLT_DECIMAL_DIG
# undef DBL_DECIMAL_DIG # undef DBL_DECIMAL_DIG
# undef LDBL_DECIMAL_DIG # undef LDBL_DECIMAL_DIG
# undef FLT_HAS_SUBNORM
# undef DBL_HAS_SUBNORM
# undef LDBL_HAS_SUBNORM
# endif # endif
#endif #endif
/* Characteristics of floating point types, C99 5.2.4.2.2 */ /* Characteristics of floating point types, C99 5.2.4.2.2 */
#define FLT_EVAL_METHOD __FLT_EVAL_METHOD__ #define FLT_EVAL_METHOD __FLT_EVAL_METHOD__
#define FLT_ROUNDS (__builtin_flt_rounds()) #define FLT_ROUNDS (__builtin_flt_rounds())
#define FLT_RADIX __FLT_RADIX__ #define FLT_RADIX __FLT_RADIX__
Show All 40 Lines
#if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) #if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__)
# define FLT_TRUE_MIN __FLT_DENORM_MIN__ # define FLT_TRUE_MIN __FLT_DENORM_MIN__
# define DBL_TRUE_MIN __DBL_DENORM_MIN__ # define DBL_TRUE_MIN __DBL_DENORM_MIN__
# define LDBL_TRUE_MIN __LDBL_DENORM_MIN__ # define LDBL_TRUE_MIN __LDBL_DENORM_MIN__
# define FLT_DECIMAL_DIG __FLT_DECIMAL_DIG__ # define FLT_DECIMAL_DIG __FLT_DECIMAL_DIG__
# define DBL_DECIMAL_DIG __DBL_DECIMAL_DIG__ # define DBL_DECIMAL_DIG __DBL_DECIMAL_DIG__
# define LDBL_DECIMAL_DIG __LDBL_DECIMAL_DIG__ # define LDBL_DECIMAL_DIG __LDBL_DECIMAL_DIG__
# define FLT_HAS_SUBNORM __FLT_HAS_DENORM__
# define DBL_HAS_SUBNORM __DBL_HAS_DENORM__
# define LDBL_HAS_SUBNORM __LDBL_HAS_DENORM__
#endif #endif
#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__ #ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
# define FLT16_MANT_DIG __FLT16_MANT_DIG__ # define FLT16_MANT_DIG __FLT16_MANT_DIG__
# define FLT16_DECIMAL_DIG __FLT16_DECIMAL_DIG__ # define FLT16_DECIMAL_DIG __FLT16_DECIMAL_DIG__
# define FLT16_DIG __FLT16_DIG__ # define FLT16_DIG __FLT16_DIG__
# define FLT16_MIN_EXP __FLT16_MIN_EXP__ # define FLT16_MIN_EXP __FLT16_MIN_EXP__
# define FLT16_MIN_10_EXP __FLT16_MIN_10_EXP__ # define FLT16_MIN_10_EXP __FLT16_MIN_10_EXP__
Show All 9 Lines

test/Headers/float.c

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines#if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__)
#ifndef LDBL_DECIMAL_DIG #ifndef LDBL_DECIMAL_DIG
#error "Mandatory macro LDBL_DECIMAL_DIG is missing." #error "Mandatory macro LDBL_DECIMAL_DIG is missing."
#elif LDBL_DECIMAL_DIG < 10 #elif LDBL_DECIMAL_DIG < 10
#error "Mandatory macro LDBL_DECIMAL_DIG is invalid." #error "Mandatory macro LDBL_DECIMAL_DIG is invalid."
#endif #endif
#if ((FLT_DECIMAL_DIG > DBL_DECIMAL_DIG) || (DBL_DECIMAL_DIG > LDBL_DECIMAL_DIG)) #if ((FLT_DECIMAL_DIG > DBL_DECIMAL_DIG) || (DBL_DECIMAL_DIG > LDBL_DECIMAL_DIG))
#error "Mandatory macros {FLT,DBL,LDBL}_DECIMAL_DIG are invalid." #error "Mandatory macros {FLT,DBL,LDBL}_DECIMAL_DIG are invalid."
#endif #endif
#ifndef FLT_HAS_SUBNORM
#error "Mandatory macro FLT_HAS_SUBNORM is missing."
#elif FLT_HAS_SUBNORM != __FLT_HAS_DENORM__
#error "Mandatory macro FLT_HAS_SUBNORM is invalid."
#endif
#ifndef LDBL_HAS_SUBNORM
#error "Mandatory macro LDBL_HAS_SUBNORM is missing."
#elif LDBL_HAS_SUBNORM != __LDBL_HAS_DENORM__
#error "Mandatory macro LDBL_HAS_SUBNORM is invalid."
#endif
#ifndef DBL_HAS_SUBNORM
#error "Mandatory macro DBL_HAS_SUBNORM is missing."
#elif DBL_HAS_SUBNORM != __DBL_HAS_DENORM__
#error "Mandatory macro DBL_HAS_SUBNORM is invalid."
#endif
#else #else
#ifdef FLT_DECIMAL_DIG #ifdef FLT_DECIMAL_DIG
#error "Macro FLT_DECIMAL_DIG should not be defined." #error "Macro FLT_DECIMAL_DIG should not be defined."
#endif #endif
#ifdef DBL_DECIMAL_DIG #ifdef DBL_DECIMAL_DIG
#error "Macro DBL_DECIMAL_DIG should not be defined." #error "Macro DBL_DECIMAL_DIG should not be defined."
#endif #endif
#ifdef LDBL_DECIMAL_DIG #ifdef LDBL_DECIMAL_DIG
#error "Macro LDBL_DECIMAL_DIG should not be defined." #error "Macro LDBL_DECIMAL_DIG should not be defined."
#endif #endif
#ifdef FLT_HAS_SUBNORM
#error "Macro FLT_HAS_SUBNORM should not be defined."
#endif
#ifdef DBL_HAS_SUBNORM
#error "Macro DBL_HAS_SUBNORM should not be defined."
#endif
#ifdef LDBL_HAS_SUBNORM
#error "Macro LDBL_HAS_SUBNORM should not be defined."
#endif
#endif #endif
#if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__) #if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__)
#ifndef DECIMAL_DIG #ifndef DECIMAL_DIG
#error "Mandatory macro DECIMAL_DIG is missing." #error "Mandatory macro DECIMAL_DIG is missing."
#elif DECIMAL_DIG < 10 #elif DECIMAL_DIG < 10
#error "Mandatory macro DECIMAL_DIG is invalid." #error "Mandatory macro DECIMAL_DIG is invalid."
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines