This is an archive of the discontinued LLVM Phabricator instance.

Differential D37144

[gold] Fix up a new test to allow it to pass on non x86 builds.
ClosedPublic

Authored by dmgreen on Aug 25 2017, 6:08 AM.

Details

Reviewers
davide
rengolin
john.brawn
eastig
tejohnson
Summary

Same deal as https://reviews.llvm.org/D28285, the test is failing on
a downstream ARM/AArch64 bootstrap. We just need to add an
elf_x86_64 parameter to gold.

Diff Detail

Event Timeline

dmgreen created this revision.Aug 25 2017, 6:08 AM
Herald added subscribers: kristof.beyls, aemerson. · View Herald TranscriptAug 25 2017, 6:08 AM
tejohnson accepted this revision.Aug 25 2017, 6:42 AM
tejohnson added a subscriber: tejohnson.

LGTM

It would be great to have a bot that catches these.

This revision is now accepted and ready to land.Aug 25 2017, 6:42 AM
dmgreen added a comment.Aug 25 2017, 7:43 AM

Thanks. Sounds sensible. I'll try and see what the Linaro guys say.

davide edited edge metadata.Aug 25 2017, 8:04 AM

LGTM. And yes, I concur a bot is essential for fixing catching these early.

davide closed this revision.Aug 25 2017, 9:20 AM

Revision Contents

PathSize
test/
tools/
gold/
X86/
2 lines

Diff 112686

test/tools/gold/X86/relocatable.ll

; RUN: llvm-as %s -o %t1.o ; RUN: llvm-as %s -o %t1.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -r %t1.o -o %t ; RUN: -r %t1.o -o %t
; RUN: llvm-readobj -symbols %t | FileCheck %s ; RUN: llvm-readobj -symbols %t | FileCheck %s