Page MenuHomePhabricator

Fix x86 gold tests on no-x86 targets

Authored by rmaprath on Jan 4 2017, 3:46 AM.



These tests are failing on our downstream arm/aarch64 builders. This is because they are missing a target triple and an -m elf_x86_64 option like the rest of the tests.

@rengolin: I noted that none of the public arm/aarch64 bots build+test LLVMgold, any particular reason? I'm thinking we'd able to catch these much sooner if that was the case.

Diff Detail


Event Timeline

rmaprath updated this revision to Diff 83027.Jan 4 2017, 3:46 AM
rmaprath retitled this revision from to Fix x86 gold tests on no-x86 targets.
rmaprath updated this object.
rmaprath added reviewers: rengolin, john.brawn, jmolloy.
rmaprath added subscribers: llvm-commits, rengolin.
tejohnson accepted this revision.Jan 4 2017, 5:56 AM
tejohnson added a reviewer: tejohnson.
tejohnson added a subscriber: tejohnson.

Thanks. A few of these have been fixed before (r286593), and I'd asked but not heard back why there isn't a bot running in that configuration. That would be good for keeping this clean!

This revision is now accepted and ready to land.Jan 4 2017, 5:56 AM
This revision was automatically updated to reflect the committed changes.