Add frontend tests for Cortex-A75 and Cortex-A55, Arm's latest big.LITTLE A-class cores. They implement the ARMv8.2-A architecture, including the cryptography and RAS extensions, plus the optional dot product extension. They also implement the RCpc AArch64 extension from ARMv8.3-A.
This change seems to have nothing to do with adding core support but exposing features from CPU names.
If this was required to "support" the new cores in Clang, why wasn't it needed before?
If this is a new, more generic way, of getting support, shouldn't you remove the specialist code that already does that for all other cores?
Why are you returning bool if you're not using the result?
Isn't this conditional redundant with what the function does?
"They also implement the RCpc AArch64 extension from ARMv8.3-A."
Perhaps you need to explain why a v8.2 core implements a v8.3 extension?
Nit: just for readability I would prefer an early exit:
if (CPU == "generic")
Nit: you're not checking the return value (so you could simplify this function, but I don't have a strong opinion on this).
CPUName != "generic" is also checked in function DecodeARMFeaturesFromCPU.
Just checking: why has the default cpu changed from generic to cortex-a55, and secondly, is that what we want?
Thanks guys, I will sort my logic out.
Renato, the new Decode function is really just there to allow me to double check the target features. This is already possible with AArch64 and it just felt right to also be able to test ARM in the same way. I've renamed the title so others aren't mislead.
I was thinking about this on the way to work, and no I don't think it is what we want! I will change this.