This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX9] Added op_sel support for v_mad_*16, v_fma_f16, v_div_fixup_f16
ClosedPublic

Authored by dp on Aug 14 2017, 9:29 AM.

Diff Detail

Event Timeline

dp created this revision.Aug 14 2017, 9:29 AM
dp planned changes to this revision.Aug 15 2017, 11:59 AM

Needs refactoring after integration of D36674

dp updated this revision to Diff 111260.Aug 15 2017, 2:46 PM
dp retitled this revision from [AMDGPU][MC][GFX9] Added op_sel support for v_mad_*16, v_fma_f16 to [AMDGPU][MC][GFX9] Added op_sel support for v_mad_*16, v_fma_f16, v_div_fixup_f16.

Updated to reflect D36674 changes. Refactored to improve readability.

SamWot edited edge metadata.Aug 16 2017, 4:50 AM

LGTM with small issue.

lib/Target/AMDGPU/VOP3Instructions.td
117

Better use HasModifiers or HasSrc0FloatMods from VOPProfile class.

SamWot accepted this revision.Aug 16 2017, 4:50 AM
This revision is now accepted and ready to land.Aug 16 2017, 4:50 AM
This revision was automatically updated to reflect the committed changes.