Page MenuHomePhabricator

[llvm] Get rid of "%T" expansions
ClosedPublic

Authored by kubamracek on Aug 8 2017, 4:28 PM.

Details

Summary

The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.

This patch removes %T in llvm.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Aug 8 2017, 4:28 PM
MatzeB accepted this revision.Aug 8 2017, 5:44 PM
MatzeB added a subscriber: MatzeB.

Thanks for doing the tedious work, LGTM. (Some of these even look like they could have caused problems with unlucky scheduling in lit).

This revision is now accepted and ready to land.Aug 8 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.