LGTM. I've been maintaining OCaml bindings for a while, but I never got the time to update the tutorial. (Ironically, that tutorial was what got me into LLVM *and* OCaml...) It is regrettable that it will be removed but I don't see another solution.

Feb 8 2021, 3:49 PM · Restricted Project

Nov 16 2020

whitequark resigned from D90831: DebugInfo support for OCaml bindings.

Nov 16 2020, 2:12 AM · Restricted Project

Oct 22 2020

whitequark resigned from D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch.

Oct 22 2020, 9:47 PM · Restricted Project, Restricted Project

Aug 28 2020

whitequark added a comment to D86748: [libunwind] Bare-metal DWARF: set dso_base to 0.

Looks overall reasonable to me, but it's been years since I touched that code or used an environment involving it, so someone else would have to sign off on it.

Aug 28 2020, 1:47 PM · Restricted Project, Restricted Project

Jul 1 2020

whitequark accepted D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path.

Jul 1 2020, 6:23 PM · Restricted Project, Restricted Project

whitequark added a comment to D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path.

Thank you for making this change. IIRC I introduced -fuse-ld= out of frustration with the inability to change the linker path in any way other than with a shell script on PATH. It was not a good design.

Jul 1 2020, 6:22 PM · Restricted Project, Restricted Project

Apr 11 2020

whitequark resigned from D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86.

I am no longer maintaining the C API.

Apr 11 2020, 10:07 AM · Restricted Project, Restricted Project

Apr 10 2020

whitequark accepted D77884: fix the documentation for ocaml bindings.

LGTM

Apr 10 2020, 10:25 AM · Restricted Project

Mar 10 2020

whitequark resigned from D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D60902: [OCaml] Add OCaml APIs to access DebugInfo.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D71126: Adding PoisonValue for representing poison value explicitly in IR.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D65138: [OCaml] Add LLVMInternalizePredicateBindings.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D72208: [bindings/go] Add methods to read debuginfo for globals.

Mar 10 2020, 2:46 PM · Restricted Project, Restricted Project

whitequark resigned from D72207: [LLVM-C][bindings/go] Get metadata from a value.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D72206: [bindings/go] Implement API for adding debug info to global variables.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark resigned from D39982: [IRBuilder] Set the insert point and debug location together.

Mar 10 2020, 2:46 PM · debug-info

whitequark resigned from D65070: [LLVM-C][OCaml] Add a fast linker binding.

Mar 10 2020, 2:46 PM · Restricted Project

whitequark added a comment to D72206: [bindings/go] Implement API for adding debug info to global variables.

@aykevl No. I'm no longer maintaining any LLVM bindings. I suggest you step up and discuss becoming a maintainer of the Go bindings on the mailing list.

Mar 10 2020, 2:46 PM · Restricted Project

Feb 25 2020

whitequark committed rG60a2db5986a8: Remove myself from CODE_OWNERS. (authored by whitequark).

Remove myself from CODE_OWNERS.

Feb 25 2020, 4:15 AM

Jan 4 2020

whitequark added a comment to D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.

Looks good now.

Jan 4 2020, 2:05 PM · Restricted Project

whitequark accepted D72209: [bindings/go] Add RemoveFromParentAsInstruction.

LGTM

Jan 4 2020, 1:55 PM · Restricted Project

Dec 27 2019

whitequark accepted D71942: Update LLVMCallConv.

LGTM, thanks

Dec 27 2019, 11:02 AM · Restricted Project

Dec 15 2019

whitequark accepted D71528: [bindings/go] Add Subprogram method.

Dec 15 2019, 9:46 AM · Restricted Project

Nov 27 2019

whitequark added a comment to D65070: [LLVM-C][OCaml] Add a fast linker binding.

@kren1 Do you have any objections to my suggestion of adding LLVMLinkInModule2? I think that's the only remaining issue to address.

Nov 27 2019, 11:46 PM · Restricted Project

Oct 11 2019

whitequark added a comment to D60902: [OCaml] Add OCaml APIs to access DebugInfo.

Would it be too strange to include such patches here?

Oct 11 2019, 11:19 AM · Restricted Project

whitequark accepted D68452: [llvm] [ocaml] Support linking against dylib.

LGTM. I did not get a notification for this before for some reason.

Oct 11 2019, 7:17 AM · Restricted Project

whitequark added a comment to D60902: [OCaml] Add OCaml APIs to access DebugInfo.

@whitequark, with this diff's approach of creating a hierarchy of types to mirror the LLVM-C DI types, is it acceptable to add the types and functions incrementally? That is, could we land this diff and add other types and functions later?

Oct 11 2019, 6:59 AM · Restricted Project

Oct 7 2019

whitequark committed rGb63db94fa547: [LLVM-C] Add bindings to create macro debug info (authored by whitequark).

[LLVM-C] Add bindings to create macro debug info

Oct 7 2019, 10:13 PM

whitequark committed rL373903: [LLVM-C] Add bindings to create macro debug info.

[LLVM-C] Add bindings to create macro debug info

Oct 7 2019, 10:13 PM

whitequark added a comment to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.

@jberdine I personally highly prefer the approach in D60902. In general, I believe that the right direction for the OCaml bindings is to evolve towards rich and type-safe accessors.

Oct 7 2019, 7:01 AM · Restricted Project

whitequark added a comment to D65070: [LLVM-C][OCaml] Add a fast linker binding.

@CodaFi Could you please comment on the current state of the patch?

Oct 7 2019, 6:59 AM · Restricted Project

whitequark closed D58334: [LLVM-C] Add bindings to create macro debug info.

Oct 7 2019, 6:56 AM · Restricted Project

whitequark added a comment to D58334: [LLVM-C] Add bindings to create macro debug info.

Done (rG373903).

Oct 7 2019, 6:56 AM · Restricted Project

Sep 21 2019

whitequark accepted D58334: [LLVM-C] Add bindings to create macro debug info.

LGTM

Sep 21 2019, 10:35 PM · Restricted Project

Sep 16 2019

whitequark committed rL372010: Request commit access for whitequark.

Request commit access for whitequark

Sep 16 2019, 9:56 AM

Sep 2 2019

whitequark added a comment to D65070: [LLVM-C][OCaml] Add a fast linker binding.

I won't be able to review this (or other patches) until at least mid-September.

Sep 2 2019, 9:51 AM · Restricted Project

Aug 17 2019

whitequark accepted D66379: [bindings/go] Add ParseIR.

LGTM

Aug 17 2019, 8:51 PM · Restricted Project

Aug 14 2019

whitequark accepted D66237: [LLVM-C] Add Bindings to the Globals Mod/Ref Alias Analysis Pass.

LGTM

Aug 14 2019, 7:05 PM · Restricted Project

Aug 13 2019

whitequark added a comment to D66144: [LLVM-C] Fix ByVal Attribute crashing.

I think the proper fix is to LLVMCreateTypeAttribute (and LLVMCreateIntAttribute)

Aug 13 2019, 11:40 AM · Restricted Project

whitequark added a comment to D66144: [LLVM-C] Fix ByVal Attribute crashing.

Can you post a link to the change that's causing the problem here? Your patch looks good but I'd like to understand it a bit better.

Aug 13 2019, 9:24 AM · Restricted Project

Jul 27 2019

whitequark added inline comments to D65070: [LLVM-C][OCaml] Add a fast linker binding.

Jul 27 2019, 5:35 AM · Restricted Project

whitequark requested changes to D65070: [LLVM-C][OCaml] Add a fast linker binding.

Jul 27 2019, 3:04 AM · Restricted Project

Jul 24 2019

whitequark accepted D65195: [OCaml] Handle nullptr in Llvm.global_initializer.

LGTM

Jul 24 2019, 11:52 AM · Restricted Project

Jul 23 2019

whitequark added inline comments to D65138: [OCaml] Add LLVMInternalizePredicateBindings.

Jul 23 2019, 9:18 AM · Restricted Project

whitequark added inline comments to D65138: [OCaml] Add LLVMInternalizePredicateBindings.

Jul 23 2019, 4:52 AM · Restricted Project

whitequark accepted D65070: [LLVM-C][OCaml] Add a fast linker binding.

LGTM

Jul 23 2019, 4:25 AM · Restricted Project

whitequark added inline comments to D65138: [OCaml] Add LLVMInternalizePredicateBindings.

Jul 23 2019, 4:09 AM · Restricted Project

whitequark accepted D65071: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass.

LGTM

Jul 23 2019, 4:09 AM · Restricted Project

May 25 2019

whitequark accepted D62456: [LLVM-C] Improve Bindings to The Internalize Pass.

LGTM. Maybe a comment about expected lifetime of Context would be useful, but it seems fairly obvious.

May 25 2019, 2:25 PM · Restricted Project

May 18 2019

whitequark abandoned D26501: [LICM] Retain load instruction invariant metadata when hoisting.

May 18 2019, 3:45 PM · Restricted Project

whitequark accepted D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.

LGTM

May 18 2019, 3:45 PM · Restricted Project

May 5 2019

whitequark accepted D61567: [llvm-c-test] Make include-all.c do what its name says it does.

May 5 2019, 3:45 PM · Restricted Project

whitequark accepted D61568: [llvm-c] Make LLVMGetStringErrorTypeId a proper prototype.

May 5 2019, 3:45 PM · Restricted Project

Apr 24 2019

whitequark accepted D61034: [bindings/go] Add wrappers for atomic operations..

LGTM

Apr 24 2019, 7:25 AM · Restricted Project

whitequark accepted D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.

LGTM

Apr 24 2019, 6:34 AM · Restricted Project

whitequark committed rG50392a3b1b84: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions (authored by whitequark).

[LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions

Apr 24 2019, 6:29 AM

whitequark committed rL359093: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.

[LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions

Apr 24 2019, 6:29 AM

whitequark closed D60473: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.

Apr 24 2019, 6:29 AM · Restricted Project

Apr 21 2019

whitequark accepted D60527: [LLVM-C] Add accessors to the default floating-point metadata node.

LGTM

Apr 21 2019, 1:10 AM · Restricted Project

Apr 16 2019

whitequark accepted D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

LGTM

Apr 16 2019, 2:35 PM · Restricted Project

whitequark committed rGd465ee662dfa: [OCaml] Update api to account for FNeg and CallBr instructions (authored by whitequark).

[OCaml] Update api to account for FNeg and CallBr instructions

Apr 16 2019, 7:59 AM

whitequark committed rL358501: [OCaml] Update api to account for FNeg and CallBr instructions.

[OCaml] Update api to account for FNeg and CallBr instructions

Apr 16 2019, 7:58 AM

whitequark closed D60680: [OCaml] Update api to account for FNeg and CallBr instructions.

Apr 16 2019, 7:58 AM · Restricted Project

Apr 15 2019

whitequark accepted D60680: [OCaml] Update api to account for FNeg and CallBr instructions.

LGTM

Apr 15 2019, 9:55 AM · Restricted Project

Apr 9 2019

whitequark accepted D60489: [LLVM-C] Add DIFile Field Accesssors.

LGTM

Apr 9 2019, 3:37 PM · Restricted Project

whitequark accepted D60484: [LLVM-C] Correct The Current Debug Location Accessors.

LGTM

Apr 9 2019, 3:28 PM · Restricted Project

whitequark added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.

Apr 9 2019, 3:11 PM · Restricted Project

whitequark accepted D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.

LGTM

Apr 9 2019, 3:11 PM · Restricted Project

whitequark added a comment to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.

I agree with @CodaFi, it's better to build on LLVMDILocation* functions here, if for no other reason that they are more robust (and not deprecated).

Apr 9 2019, 2:53 PM · Restricted Project

whitequark added inline comments to D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.

Apr 9 2019, 2:53 PM · Restricted Project

whitequark added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.

Apr 9 2019, 2:49 PM · Restricted Project

whitequark accepted D60473: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.

So, these are going to be deprecated in D60484, but I see no harm in merging this patch, as it's a straightforward bugfix.

Apr 9 2019, 2:48 PM · Restricted Project

whitequark added a comment to D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

Yup, good catch! I'll make sure to check for this in the future as well.

Apr 9 2019, 2:45 PM · Restricted Project

Apr 8 2019

whitequark accepted D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

LGTM

Apr 8 2019, 7:46 AM · Restricted Project

Apr 6 2019

whitequark accepted D60366: [LLVM-C] Allow Access to the Type of a Binary.

Apr 6 2019, 9:39 PM · Restricted Project

Apr 5 2019

whitequark accepted D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

LGTM

Apr 5 2019, 1:55 PM · Restricted Project

whitequark accepted D59658: [LLVM-C] Add bindings to insert basic blocks.

LGTM

Apr 5 2019, 1:28 PM · Restricted Project

whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

Sure.

Apr 5 2019, 1:08 PM · Restricted Project

whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

Agreed; I think it should still have Existing in the name if it takes a reference to a block, to distinguish from the existing set of (somewhat poorly named) functions.

Apr 5 2019, 1:00 PM · Restricted Project

whitequark added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

SGTM, just one question about ownership.

Apr 5 2019, 12:44 PM · Restricted Project

whitequark added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

Can you provide a bit more context for this change? It looks good, I just want to understand the plan here in more detail.

Apr 5 2019, 12:28 PM · Restricted Project

whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

I think the names are confusing. Why not something like LLVMInsertExistingBasicBlock and LLVMAppendExistingBasicBlock?

Apr 5 2019, 12:24 PM · Restricted Project