whitequark (whitequark)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2013, 11:58 AM (299 w, 3 d)

Recent Activity

Mon, Oct 15

whitequark added a comment to D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

@george-hopkins Thanks, I will take a look.

Mon, Oct 15, 7:24 AM

Sun, Oct 14

whitequark accepted D53262: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.

LGTM, thanks for fixing this!

Sun, Oct 14, 7:24 PM

Wed, Oct 10

whitequark accepted D52210: [LLVM-C] Add C APIs to access DebugLoc info.

Looks good to me now, thanks @compnerd !

Wed, Oct 10, 12:39 PM

Mon, Oct 8

whitequark accepted D52972: [bindings/go] Add Go bindings for CalledValue.
Mon, Oct 8, 11:03 AM

Sat, Sep 29

whitequark accepted D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.

LGTM, thanks!

Sat, Sep 29, 3:34 PM
whitequark added inline comments to D52694: [bindings/go] Add EraseFromParent.
Sat, Sep 29, 9:13 AM
whitequark added inline comments to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sat, Sep 29, 8:50 AM
whitequark requested changes to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sat, Sep 29, 8:42 AM

Fri, Sep 28

whitequark committed rL343345: [bindings/go] Add Go bindings to the Token type.
[bindings/go] Add Go bindings to the Token type
Fri, Sep 28, 10:42 AM
whitequark closed D47684: [bindings/go] Add Go bindings to the Token type.
Fri, Sep 28, 10:42 AM
whitequark committed rL343339: [bindings/go] Add Go bindings for inline assembly.
[bindings/go] Add Go bindings for inline assembly
Fri, Sep 28, 9:50 AM
whitequark closed D46437: [bindings/go] Add Go bindings for inline assembly.
Fri, Sep 28, 9:50 AM
whitequark added a comment to D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.

This broke the bots; the LLVM-C API you added should really be in Transforms/Coroutines, not Transforms/IPO. Please update the patch.

Fri, Sep 28, 9:50 AM
whitequark committed rL343337: Revert "[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints".
Revert "[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints"
Fri, Sep 28, 9:46 AM
whitequark committed rL343336: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.
[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints
Fri, Sep 28, 9:39 AM
whitequark closed D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.
Fri, Sep 28, 9:39 AM
whitequark accepted D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Fri, Sep 28, 9:25 AM
whitequark accepted D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

LGTM

Fri, Sep 28, 8:07 AM

Tue, Sep 25

whitequark resigned from D52057: Emit template type and value parameter DIEs for template variables..
Tue, Sep 25, 12:49 PM · debug-info

Sep 18 2018

whitequark added a reviewer for D52210: [LLVM-C] Add C APIs to access DebugLoc info: echristo.

@deadalnix, @echristo, any opinion on this C API?

Sep 18 2018, 9:36 AM
whitequark committed rL342476: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
[LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs
Sep 18 2018, 6:37 AM
whitequark closed D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
Sep 18 2018, 6:37 AM
whitequark committed rL342475: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
[LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs
Sep 18 2018, 6:37 AM
whitequark closed D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 18 2018, 6:37 AM
whitequark committed rL342474: [OCaml] Add OCaml API for LLVMGetIndices.
[OCaml] Add OCaml API for LLVMGetIndices
Sep 18 2018, 6:37 AM
whitequark closed D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 18 2018, 6:37 AM
whitequark accepted D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.

Ah yes, in this case the C API name (and when adding a C API, C++ API name) would be preferred over opt -help, since I imagine that anyone writing code against LLVM bindings would consult doxygen.

Sep 18 2018, 6:36 AM
whitequark accepted D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 18 2018, 6:32 AM
whitequark accepted D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 18 2018, 6:31 AM

Sep 17 2018

whitequark committed rL342438: [OCaml] Add OCaml API for LLVMIsCleanup.
[OCaml] Add OCaml API for LLVMIsCleanup
Sep 17 2018, 6:52 PM
whitequark committed rL342437: [NFC][OCaml] Fix copy paste error in file header.
[NFC][OCaml] Fix copy paste error in file header
Sep 17 2018, 6:52 PM
whitequark closed D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:51 PM
whitequark closed D52215: [NFC][OCaml] Fix copy paste error in file header.
Sep 17 2018, 6:51 PM
whitequark committed rL342435: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
[LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral
Sep 17 2018, 6:51 PM
whitequark committed rL342436: [NFC][OCaml] Fix implicit declaration compilation warnings.
[NFC][OCaml] Fix implicit declaration compilation warnings
Sep 17 2018, 6:51 PM
whitequark closed D52209: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
Sep 17 2018, 6:51 PM
whitequark closed D52214: [NFC][OCaml] Fix implicit declaration compilation warnings.
Sep 17 2018, 6:51 PM
whitequark committed rL342434: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
[LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices
Sep 17 2018, 6:51 PM
whitequark closed D52206: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
Sep 17 2018, 6:51 PM
whitequark committed rL342433: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
[OCaml] Add OCaml APIs for Invoke arguments and destinations
Sep 17 2018, 6:51 PM
whitequark closed D52204: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
Sep 17 2018, 6:51 PM
whitequark accepted D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:47 PM
whitequark accepted D52215: [NFC][OCaml] Fix copy paste error in file header.
Sep 17 2018, 6:47 PM
whitequark accepted D52214: [NFC][OCaml] Fix implicit declaration compilation warnings.
Sep 17 2018, 6:46 PM
whitequark requested changes to D52213: [OCaml] Add OCaml API for __cxa_demangle.

I'm not sure if this function has a place here. It's not a function provided by the LLVM API, and it's platform-specific. I think with this change it would not be possible to build the OCaml bindings under MSVC, for example.

Sep 17 2018, 6:46 PM
whitequark requested changes to D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
Sep 17 2018, 6:44 PM
whitequark added inline comments to D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 17 2018, 6:44 PM
whitequark requested changes to D52210: [LLVM-C] Add C APIs to access DebugLoc info.

Why are there three sets of functions that all operate on LLVMValueRef? Can't we make it a single set of functions?

Sep 17 2018, 6:42 PM
whitequark accepted D52209: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
Sep 17 2018, 6:39 PM
whitequark requested changes to D52208: [OCaml] Add OCaml APIs for LLVMGetModuleDataLayout and LLVMABISizeOfType.

There is already an Llvm_target.DataLayout.t, we don't need to wrap it the second time.

Sep 17 2018, 6:39 PM
whitequark added inline comments to D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 17 2018, 6:38 PM
whitequark added inline comments to D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 17 2018, 6:38 PM
whitequark accepted D52206: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
Sep 17 2018, 6:34 PM
whitequark added inline comments to D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:34 PM
whitequark accepted D52204: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
Sep 17 2018, 6:32 PM
whitequark committed rL342429: [OCaml] Add GlobalIFunc value kind to OCaml API.
[OCaml] Add GlobalIFunc value kind to OCaml API
Sep 17 2018, 5:04 PM
whitequark committed rL342428: [OCaml] Add Token type to kind enum in OCaml API.
[OCaml] Add Token type to kind enum in OCaml API
Sep 17 2018, 5:04 PM
whitequark closed D52198: [OCaml] Add GlobalIFunc value kind to OCaml API.
Sep 17 2018, 5:03 PM
whitequark closed D52197: [OCaml] Add Token type to kind enum in OCaml API.
Sep 17 2018, 5:03 PM
whitequark committed rL342427: [OCaml] Add missing instruction opcodes to OCaml API.
[OCaml] Add missing instruction opcodes to OCaml API
Sep 17 2018, 5:03 PM
whitequark closed D52196: [OCaml] Add missing instruction opcodes to OCaml API.
Sep 17 2018, 5:03 PM
whitequark accepted D52198: [OCaml] Add GlobalIFunc value kind to OCaml API.

LGTM

Sep 17 2018, 4:47 PM
whitequark accepted D52197: [OCaml] Add Token type to kind enum in OCaml API.

LGTM

Sep 17 2018, 4:46 PM
whitequark accepted D52196: [OCaml] Add missing instruction opcodes to OCaml API.

Thanks!

Sep 17 2018, 4:19 PM

Sep 15 2018

whitequark accepted D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.

LGTM

Sep 15 2018, 12:02 AM

Aug 30 2018

whitequark added inline comments to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 30 2018, 10:17 PM
whitequark added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

How is a user of this API supposed to map the unsigned Kind values to something meaningful? We don't have an enum LLVMMetadataKind, do we?

Aug 30 2018, 5:07 PM
whitequark accepted D47179: [LLVM-C] Add Bindings For Named Metadata.

LGTM

Aug 30 2018, 9:51 AM

Aug 19 2018

whitequark committed rL340148: [bindings/go] Add coroutine passes.
[bindings/go] Add coroutine passes
Aug 19 2018, 4:41 PM
whitequark closed D50951: [bindings/go] Add coroutine passes.
Aug 19 2018, 4:40 PM
whitequark committed rL340147: [LLVM-C] Add coroutine passes.
[LLVM-C] Add coroutine passes
Aug 19 2018, 4:40 PM
whitequark closed D50950: [LLVM-C] Add coroutine passes.
Aug 19 2018, 4:40 PM
whitequark committed rL340146: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
[C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType
Aug 19 2018, 4:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Aug 19 2018, 4:40 PM
whitequark accepted D50951: [bindings/go] Add coroutine passes.
Aug 19 2018, 4:38 PM
whitequark accepted D50950: [LLVM-C] Add coroutine passes.
Aug 19 2018, 3:53 PM

Aug 15 2018

whitequark accepted D47684: [bindings/go] Add Go bindings to the Token type.
Aug 15 2018, 11:40 PM
whitequark accepted D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
Aug 15 2018, 11:39 PM

Jul 23 2018

whitequark accepted D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp..
Jul 23 2018, 11:00 PM

Jul 17 2018

whitequark committed rL337264: [LLVM-C] Fix name mangling on AggressiveInstCombine.
[LLVM-C] Fix name mangling on AggressiveInstCombine
Jul 17 2018, 4:19 AM
whitequark closed D49416: [LLVM-C] Fix name mangling on AggressiveInstCombine.
Jul 17 2018, 4:19 AM
whitequark committed rL337263: [LLVM-C] Add target triple normalization to the C API..
[LLVM-C] Add target triple normalization to the C API.
Jul 17 2018, 4:02 AM
whitequark closed D49414: Add target triple normalization to the C API.
Jul 17 2018, 4:02 AM
whitequark accepted D49414: Add target triple normalization to the C API.

LGTM, thanks!

Jul 17 2018, 3:59 AM
whitequark accepted D49416: [LLVM-C] Fix name mangling on AggressiveInstCombine.

LGTM

Jul 17 2018, 3:03 AM
whitequark requested changes to D49414: Add target triple normalization to the C API.
Jul 17 2018, 3:02 AM

Jun 5 2018

whitequark added a comment to D25265: [C API] Add test for D25259 and new LLVMIsExact function..

I think we need to add LLVMSetExact as well.

Jun 5 2018, 4:04 PM

May 29 2018

whitequark added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

It would be nice if we had a test case added for this

May 29 2018, 7:52 PM

May 23 2018

whitequark added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

@compnerd ping

May 23 2018, 2:40 PM
whitequark resigned from D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

Resigning to get out of my queue--retag me if there's any progress.

May 23 2018, 2:39 PM
whitequark resigned from D19088: [Draft] Possible mapping of DIBuilder in the C API.
May 23 2018, 2:39 PM

May 22 2018

whitequark added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

C API changes LGTM.

May 22 2018, 9:05 AM

May 20 2018

whitequark accepted D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.

Thanks!

May 20 2018, 4:57 PM
whitequark accepted D46808: [LLVM-C] Improve Bindings For Aliases.

Thanks!

May 20 2018, 12:04 PM

May 19 2018

whitequark accepted D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

Thanks!

May 19 2018, 3:35 AM

May 17 2018

whitequark requested changes to D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

First, the naming here is absurdly confusing. Second, it's also inconsistent with all other functions, e.g. LLVMGetSourceFileName/LLVMSetSourceFileName.

May 17 2018, 12:42 AM

May 16 2018

whitequark updated the diff for D46971: [DWARF] Get RA from RA register even if it appears unused.

Reuploaded diff with context.

May 16 2018, 12:22 PM
whitequark created D46971: [DWARF] Get RA from RA register even if it appears unused.
May 16 2018, 12:17 PM
whitequark committed rUNW332513: [OR1K] Add the EPCR special-purpose register to register state..
[OR1K] Add the EPCR special-purpose register to register state.
May 16 2018, 12:13 PM
whitequark committed rUNW332512: [OR1K] Add a dedicated PC register to register state..
[OR1K] Add a dedicated PC register to register state.
May 16 2018, 12:13 PM