whitequark (whitequark)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2013, 11:58 AM (290 w, 1 d)

Recent Activity

Mon, Jul 23

whitequark accepted D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp..
Mon, Jul 23, 11:00 PM

Tue, Jul 17

whitequark committed rL337264: [LLVM-C] Fix name mangling on AggressiveInstCombine.
[LLVM-C] Fix name mangling on AggressiveInstCombine
Tue, Jul 17, 4:19 AM
whitequark closed D49416: [LLVM-C] Fix name mangling on AggressiveInstCombine.
Tue, Jul 17, 4:19 AM
whitequark committed rL337263: [LLVM-C] Add target triple normalization to the C API..
[LLVM-C] Add target triple normalization to the C API.
Tue, Jul 17, 4:02 AM
whitequark closed D49414: Add target triple normalization to the C API.
Tue, Jul 17, 4:02 AM
whitequark accepted D49414: Add target triple normalization to the C API.

LGTM, thanks!

Tue, Jul 17, 3:59 AM
whitequark accepted D49416: [LLVM-C] Fix name mangling on AggressiveInstCombine.

LGTM

Tue, Jul 17, 3:03 AM
whitequark requested changes to D49414: Add target triple normalization to the C API.
Tue, Jul 17, 3:02 AM

Jun 5 2018

whitequark added a comment to D25265: [C API] Add test for D25259 and new LLVMIsExact function..

I think we need to add LLVMSetExact as well.

Jun 5 2018, 4:04 PM

May 29 2018

whitequark added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

It would be nice if we had a test case added for this

May 29 2018, 7:52 PM

May 23 2018

whitequark added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

@compnerd ping

May 23 2018, 2:40 PM
whitequark resigned from D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

Resigning to get out of my queue--retag me if there's any progress.

May 23 2018, 2:39 PM
whitequark resigned from D19088: [Draft] Possible mapping of DIBuilder in the C API.
May 23 2018, 2:39 PM

May 22 2018

whitequark added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

C API changes LGTM.

May 22 2018, 9:05 AM

May 20 2018

whitequark accepted D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.

Thanks!

May 20 2018, 4:57 PM
whitequark accepted D46808: [LLVM-C] Improve Bindings For Aliases.

Thanks!

May 20 2018, 12:04 PM

May 19 2018

whitequark accepted D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

Thanks!

May 19 2018, 3:35 AM

May 17 2018

whitequark requested changes to D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

First, the naming here is absurdly confusing. Second, it's also inconsistent with all other functions, e.g. LLVMGetSourceFileName/LLVMSetSourceFileName.

May 17 2018, 12:42 AM

May 16 2018

whitequark updated the diff for D46971: [DWARF] Get RA from RA register even if it appears unused.

Reuploaded diff with context.

May 16 2018, 12:22 PM
whitequark created D46971: [DWARF] Get RA from RA register even if it appears unused.
May 16 2018, 12:17 PM
whitequark committed rUNW332513: [OR1K] Add the EPCR special-purpose register to register state..
[OR1K] Add the EPCR special-purpose register to register state.
May 16 2018, 12:13 PM
whitequark committed rUNW332512: [OR1K] Add a dedicated PC register to register state..
[OR1K] Add a dedicated PC register to register state.
May 16 2018, 12:13 PM
whitequark committed rL332513: [OR1K] Add the EPCR special-purpose register to register state..
[OR1K] Add the EPCR special-purpose register to register state.
May 16 2018, 12:13 PM
whitequark committed rL332512: [OR1K] Add a dedicated PC register to register state..
[OR1K] Add a dedicated PC register to register state.
May 16 2018, 12:13 PM

May 15 2018

whitequark committed rL332342: [MergeFunctions] Fix merging of small weak functions.
[MergeFunctions] Fix merging of small weak functions
May 15 2018, 4:35 AM
whitequark closed D46804: Fix merging of small weak functions.
May 15 2018, 4:35 AM
whitequark accepted D46804: Fix merging of small weak functions.

LGTM

May 15 2018, 12:49 AM

May 13 2018

whitequark accepted D46792: [LLVM-C] Add Bindings For Module Flags.
May 13 2018, 10:58 PM
whitequark added a comment to D46792: [LLVM-C] Add Bindings For Module Flags.

The data for the entries is owned by the module, the array is just an adapter for those entries - the user need only free. I can provide an explicit dispose for this in case we decide to change that user model or for clarity if you want.

May 13 2018, 10:50 PM
whitequark requested changes to D46792: [LLVM-C] Add Bindings For Module Flags.
May 13 2018, 9:55 PM
whitequark requested changes to D46808: [LLVM-C] Improve Bindings For Aliases.
May 13 2018, 6:54 PM
whitequark added a comment to D46804: Fix merging of small weak functions.

Thanks for fixing this!

May 13 2018, 7:13 AM

May 10 2018

whitequark accepted D46725: [LLVM-C] Consolidate llgo's DIBuilder Bindings.

Excellent work!

May 10 2018, 2:11 PM
whitequark accepted D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

OK, looking forward to that then!

May 10 2018, 11:23 AM
whitequark committed rL331990: [PR37339] Fix assertion in FunctionComparator::cmpInlineAsm.
[PR37339] Fix assertion in FunctionComparator::cmpInlineAsm
May 10 2018, 8:09 AM
whitequark closed D46495: Fix assertion in FunctionComparator::cmpInlineAsm.
May 10 2018, 8:09 AM
whitequark added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

You could write the same tests as in llvm-c-test/echo.cpp. But I would not block merging on this.

May 10 2018, 7:51 AM
whitequark accepted D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.

llvm::Value::replaceAllUsesWith and llvm::MDNode::replaceAllUsesWith are distinct operations.

May 10 2018, 7:48 AM

May 9 2018

whitequark added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

Any tests?

May 9 2018, 6:29 AM
whitequark requested changes to D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
May 9 2018, 6:24 AM

Apr 29 2018

whitequark accepted D46235: [bindings/go] Add Go bindings for volatile loads/stores.

This one is fine, but note that I don't use Go and cannot review non-trivial Go patches.

Apr 29 2018, 5:50 AM

Apr 28 2018

whitequark added a comment to D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.

@thakis rL331132.

Apr 28 2018, 7:05 PM
whitequark committed rL331132: [LLVM-C] Eliminate an unused variable in a test..
[LLVM-C] Eliminate an unused variable in a test.
Apr 28 2018, 7:05 PM
whitequark accepted D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.

LGTM

Apr 28 2018, 12:08 AM

Apr 27 2018

whitequark added a comment to D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.

Did these ever appear in a release? They change ABI, so if yes, this needs renaming every function to a *2 variant.

Apr 27 2018, 1:41 PM
whitequark added a comment to D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

I think it's worth asking on llvm-dev as to what kind of API is this.

Apr 27 2018, 1:41 PM
whitequark accepted D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.

LGTM, thanks!

Apr 27 2018, 1:19 PM

Apr 23 2018

whitequark accepted D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.

LGTM, thanks!

Apr 23 2018, 12:35 PM
whitequark accepted D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.

LGTM, thanks!

Apr 23 2018, 7:31 AM
whitequark accepted D45934: [LLVM-C] Finish Up Scope Bindings.

LGTM, thanks!

Apr 23 2018, 1:51 AM
whitequark added inline comments to D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 23 2018, 1:50 AM

Apr 22 2018

whitequark accepted D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.

LGTM

Apr 22 2018, 8:00 AM

Apr 17 2018

whitequark committed rL330189: [LLVM-C] [PR34633] Avoid calling ->dump() methods from LLVMDump*..
[LLVM-C] [PR34633] Avoid calling ->dump() methods from LLVMDump*.
Apr 17 2018, 7:56 AM
whitequark closed D44600: Fix LLVMDumpType() #ifdefed.
Apr 17 2018, 7:56 AM
whitequark added a comment to D44600: Fix LLVMDumpType() #ifdefed.

Um, sorry, I mean only in the C API (extern "C" LLVM* methods). LLVM_DUMP_METHOD *does* serve a function in the C++ API.

Apr 17 2018, 7:11 AM

Apr 16 2018

whitequark added a comment to D44600: Fix LLVMDumpType() #ifdefed.

Thanks for the patch! Can you also remove LLVM_DUMP_METHOD here and elsewhere in the C API? It doesn't do anything useful.

Apr 16 2018, 6:16 PM
whitequark committed rL330171: CODE_OWNERS: Take ownership of C API..
CODE_OWNERS: Take ownership of C API.
Apr 16 2018, 6:14 PM

Apr 11 2018

whitequark committed rL329856: [LLVM-C] Add LLVMGetHostCPU{Name,Features}..
[LLVM-C] Add LLVMGetHostCPU{Name,Features}.
Apr 11 2018, 3:46 PM
whitequark closed D44861: [C-API] Add LLVMGetHostCPU{Name,Features}..
Apr 11 2018, 3:46 PM
whitequark accepted D44861: [C-API] Add LLVMGetHostCPU{Name,Features}..

LGTM. Ideally we would have a test for this code but given that it involves host CPU and features this seems quite tricky and not worth the benefit.

Apr 11 2018, 3:36 PM
whitequark added a reviewer for D44861: [C-API] Add LLVMGetHostCPU{Name,Features}.: whitequark.
Apr 11 2018, 3:26 PM

Apr 7 2018

whitequark accepted D45402: [llgo] Move SetSubprogram.
Apr 7 2018, 1:17 AM

Apr 6 2018

whitequark accepted D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.

LGTM

Apr 6 2018, 12:23 PM
whitequark updated the diff for D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

Fix a typo.

Apr 6 2018, 2:17 AM
whitequark created D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.
Apr 6 2018, 12:24 AM

Apr 5 2018

whitequark added a comment to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.

Sounds like a plan.

Apr 5 2018, 9:13 PM
whitequark added a comment to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.

Do you think you could add a test? (Do we have tests for DIBuilder at all?)

Apr 5 2018, 9:07 PM
whitequark accepted D45347: [LLVM-C] Fill Out LLVMCallConv.
Apr 5 2018, 8:05 PM
whitequark accepted D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 7:25 PM
whitequark added inline comments to D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 7:15 PM
whitequark requested changes to D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.

Oh sorry, I've missed one API issue.

Apr 5 2018, 7:14 PM
whitequark accepted D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.

Excellent work, thanks!

Apr 5 2018, 7:12 PM

Mar 30 2018

whitequark accepted D45100: [LLVM-C] Finish exception instruction bindings - Round 2.

I would say in case of trivial changes like this you can just recommit it if you can confirm that it passes ASAN.

Mar 30 2018, 10:49 AM
whitequark accepted D39564: Add DIBuilder Type APIs to C API.
Mar 30 2018, 1:13 AM

Mar 15 2018

whitequark added a reviewer for D44496: [LLVM-C] Finish exception instruction bindings: echristo.
Mar 15 2018, 10:18 PM

Mar 14 2018

whitequark added a comment to D44496: [LLVM-C] Finish exception instruction bindings.

This looks reasonable to me, but I'm not familiar with funclet EH, so I'd like someone else to take a second look.

Mar 14 2018, 6:01 PM

Feb 19 2018

whitequark added a comment to D43107: Support for the mno-stack-arg-probe flag.

I don't really know what the current stack-probe-size=0 would be useful for; but then again I'm not actively working on it either.

Feb 19 2018, 5:27 PM

Feb 18 2018

whitequark accepted D43448: [LLVM-C] Redo unnamed_address attribute bindings.
Feb 18 2018, 9:47 PM

Jan 28 2018

whitequark accepted D42618: [LLVM-C] Add Accessors For A Module's Source File Name.
Jan 28 2018, 11:39 AM
whitequark added inline comments to D42618: [LLVM-C] Add Accessors For A Module's Source File Name.
Jan 28 2018, 6:00 AM

Dec 25 2017

whitequark committed rL321448: [libunwind] Remove dubious template function. NFC..
[libunwind] Remove dubious template function. NFC.
Dec 25 2017, 1:09 PM
whitequark committed rL321446: [libunwind] Unbreak debug builds after r321440..
[libunwind] Unbreak debug builds after r321440.
Dec 25 2017, 12:05 PM
whitequark committed rL321445: [libunwind] Add proper support for DWARF unwind on bare metal..
[libunwind] Add proper support for DWARF unwind on bare metal.
Dec 25 2017, 9:06 AM
whitequark committed rL321442: [libunwind] fix a typo in r321441..
[libunwind] fix a typo in r321441.
Dec 25 2017, 5:43 AM
whitequark committed rL321441: [libunwind] convert error logs to _LIBUNWIND_LOG/_LIBUNWIND_LOG0..
[libunwind] convert error logs to _LIBUNWIND_LOG/_LIBUNWIND_LOG0.
Dec 25 2017, 5:29 AM
whitequark committed rL321440: [libunwind] Avoid using C++ headers..
[libunwind] Avoid using C++ headers.
Dec 25 2017, 5:07 AM

Dec 19 2017

whitequark added a comment to D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

how could OCaml bindings be turned off in LLVM if OCaml is installed at configure time? (and avoiding the package lookup if it's not needed?)

Dec 19 2017, 3:19 AM
whitequark requested changes to D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

Whether the bindings are enabled have nothing to do with whether ocamldoc is. Fix your automated checker.

Dec 19 2017, 2:42 AM

Dec 18 2017

whitequark added a comment to D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

Why?

Dec 18 2017, 9:48 AM

Dec 8 2017

whitequark added inline comments to D39982: [IRBuilder] Set the insert point and debug location together.
Dec 8 2017, 4:15 PM · debug-info

Dec 7 2017

whitequark added inline comments to D39982: [IRBuilder] Set the insert point and debug location together.
Dec 7 2017, 8:44 PM · debug-info

Dec 6 2017

whitequark requested changes to D39982: [IRBuilder] Set the insert point and debug location together.
Dec 6 2017, 8:48 AM · debug-info

Nov 3 2017

whitequark added a comment to D39564: Add DIBuilder Type APIs to C API.

@harlanhaskins Since you already have one patch in, can you please ask for commit access (see the LLVM docs for how to do it) and commit this yourself?

Nov 3 2017, 3:24 AM

Nov 2 2017

whitequark accepted D39564: Add DIBuilder Type APIs to C API.
Nov 2 2017, 1:44 PM

Nov 1 2017

whitequark committed rL317135: [LLVM-C] Expose functions to create debug locations via DIBuilder..
[LLVM-C] Expose functions to create debug locations via DIBuilder.
Nov 1 2017, 3:19 PM
whitequark closed D32368: LLVM C DIBuilder Creation APIs by committing rL317135: [LLVM-C] Expose functions to create debug locations via DIBuilder..
Nov 1 2017, 3:19 PM

Oct 31 2017

whitequark added a comment to D32368: LLVM C DIBuilder Creation APIs.

Please rebase the patch, it doesn't apply as-is.

Oct 31 2017, 11:36 PM
whitequark added a comment to D32368: LLVM C DIBuilder Creation APIs.

Sure, go ahead and commit.

Oct 31 2017, 2:22 AM

Oct 27 2017

whitequark committed rL316762: [LLVM-C] Publicly expose getters of MetadataType, TokenType.
[LLVM-C] Publicly expose getters of MetadataType, TokenType
Oct 27 2017, 4:52 AM
whitequark closed D38809: [LLVM-C] Publicly expose getters of MetadataType, TokenType by committing rL316762: [LLVM-C] Publicly expose getters of MetadataType, TokenType.
Oct 27 2017, 4:52 AM