Page MenuHomePhabricator

whitequark (whitequark)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2013, 11:58 AM (308 w, 1 d)

Recent Activity

Nov 7 2018

whitequark committed rL346388: [bindings/go] Add Go bindings to LLVMGetIndices.
[bindings/go] Add Go bindings to LLVMGetIndices
Nov 7 2018, 8:06 PM
whitequark closed D53883: [bindings/go] Add Go bindings to LLVMGetIndices.
Nov 7 2018, 8:06 PM
whitequark committed rL346387: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
[OCaml] Fix incorrect use of CAMLlocal in nested blocks
Nov 7 2018, 8:04 PM
whitequark closed D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
Nov 7 2018, 8:04 PM
whitequark added a comment to D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.

@CodaFi Did you mean to commentn on D52210? I'm confused here...

Nov 7 2018, 8:04 PM
whitequark committed rL346386: [MergeFuncs] Improve ordering of equal functions.
[MergeFuncs] Improve ordering of equal functions
Nov 7 2018, 8:00 PM
whitequark closed D53271: [MergeFuncs] Improve ordering of equal functions.
Nov 7 2018, 8:00 PM
whitequark committed rL346385: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.
[MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW
Nov 7 2018, 8:00 PM
whitequark added a comment to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).

As I don't have commit rights, could you please commit D53262, D53271 and this revision?

Nov 7 2018, 8:00 PM
whitequark closed D53262: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.
Nov 7 2018, 8:00 PM

Oct 31 2018

whitequark accepted D53883: [bindings/go] Add Go bindings to LLVMGetIndices.
Oct 31 2018, 12:38 AM

Oct 29 2018

whitequark accepted D52239: [OCaml] Add OCaml APIs to access DebugLoc info.
Oct 29 2018, 3:52 PM
whitequark accepted D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
Oct 29 2018, 3:51 PM
whitequark accepted D53626: [LLVM-C] Improve Intrinsics Bindings.
Oct 29 2018, 9:25 AM
whitequark accepted D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 29 2018, 3:19 AM
whitequark added inline comments to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 29 2018, 2:57 AM
whitequark accepted D52694: [bindings/go] Add EraseFromParent.
Oct 29 2018, 12:00 AM

Oct 28 2018

whitequark added inline comments to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.
Oct 28 2018, 11:57 PM
whitequark added inline comments to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 28 2018, 11:55 PM
whitequark accepted D53271: [MergeFuncs] Improve ordering of equal functions.
Oct 28 2018, 11:52 PM
whitequark requested changes to D53626: [LLVM-C] Improve Intrinsics Bindings.

LGTM other than the argument types.

Oct 28 2018, 11:52 PM
whitequark accepted D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.

LGTM, and I am OK with merging a test later if that is more convenient. This is not a particularly complex change.

Oct 28 2018, 11:52 PM

Oct 15 2018

whitequark added a comment to D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

@george-hopkins Thanks, I will take a look.

Oct 15 2018, 7:24 AM

Oct 14 2018

whitequark accepted D53262: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.

LGTM, thanks for fixing this!

Oct 14 2018, 7:24 PM

Oct 10 2018

whitequark accepted D52210: [LLVM-C] Add C APIs to access DebugLoc info.

Looks good to me now, thanks @compnerd !

Oct 10 2018, 12:39 PM

Oct 8 2018

whitequark accepted D52972: [bindings/go] Add Go bindings for CalledValue.
Oct 8 2018, 11:03 AM

Sep 29 2018

whitequark accepted D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.

LGTM, thanks!

Sep 29 2018, 3:34 PM
whitequark added inline comments to D52694: [bindings/go] Add EraseFromParent.
Sep 29 2018, 9:13 AM
whitequark added inline comments to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:50 AM
whitequark requested changes to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:42 AM

Sep 28 2018

whitequark committed rL343345: [bindings/go] Add Go bindings to the Token type.
[bindings/go] Add Go bindings to the Token type
Sep 28 2018, 10:42 AM
whitequark closed D47684: [bindings/go] Add Go bindings to the Token type.
Sep 28 2018, 10:42 AM
whitequark committed rL343339: [bindings/go] Add Go bindings for inline assembly.
[bindings/go] Add Go bindings for inline assembly
Sep 28 2018, 9:50 AM
whitequark closed D46437: [bindings/go] Add Go bindings for inline assembly.
Sep 28 2018, 9:50 AM
whitequark added a comment to D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.

This broke the bots; the LLVM-C API you added should really be in Transforms/Coroutines, not Transforms/IPO. Please update the patch.

Sep 28 2018, 9:50 AM
whitequark committed rL343337: Revert "[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints".
Revert "[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints"
Sep 28 2018, 9:46 AM
whitequark committed rL343336: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.
[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints
Sep 28 2018, 9:39 AM
whitequark closed D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.
Sep 28 2018, 9:39 AM
whitequark accepted D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Sep 28 2018, 9:25 AM
whitequark accepted D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

LGTM

Sep 28 2018, 8:07 AM

Sep 25 2018

whitequark resigned from D52057: Emit template type and value parameter DIEs for template variables..
Sep 25 2018, 12:49 PM · debug-info

Sep 18 2018

whitequark added a reviewer for D52210: [LLVM-C] Add C APIs to access DebugLoc info: echristo.

@deadalnix, @echristo, any opinion on this C API?

Sep 18 2018, 9:36 AM
whitequark committed rL342476: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
[LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs
Sep 18 2018, 6:37 AM
whitequark closed D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
Sep 18 2018, 6:37 AM
whitequark committed rL342475: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
[LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs
Sep 18 2018, 6:37 AM
whitequark closed D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 18 2018, 6:37 AM
whitequark committed rL342474: [OCaml] Add OCaml API for LLVMGetIndices.
[OCaml] Add OCaml API for LLVMGetIndices
Sep 18 2018, 6:37 AM
whitequark closed D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 18 2018, 6:37 AM
whitequark accepted D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.

Ah yes, in this case the C API name (and when adding a C API, C++ API name) would be preferred over opt -help, since I imagine that anyone writing code against LLVM bindings would consult doxygen.

Sep 18 2018, 6:36 AM
whitequark accepted D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 18 2018, 6:32 AM
whitequark accepted D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 18 2018, 6:31 AM

Sep 17 2018

whitequark committed rL342438: [OCaml] Add OCaml API for LLVMIsCleanup.
[OCaml] Add OCaml API for LLVMIsCleanup
Sep 17 2018, 6:52 PM
whitequark committed rL342437: [NFC][OCaml] Fix copy paste error in file header.
[NFC][OCaml] Fix copy paste error in file header
Sep 17 2018, 6:52 PM
whitequark closed D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:51 PM
whitequark closed D52215: [NFC][OCaml] Fix copy paste error in file header.
Sep 17 2018, 6:51 PM
whitequark committed rL342435: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
[LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral
Sep 17 2018, 6:51 PM
whitequark committed rL342436: [NFC][OCaml] Fix implicit declaration compilation warnings.
[NFC][OCaml] Fix implicit declaration compilation warnings
Sep 17 2018, 6:51 PM
whitequark closed D52209: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
Sep 17 2018, 6:51 PM
whitequark closed D52214: [NFC][OCaml] Fix implicit declaration compilation warnings.
Sep 17 2018, 6:51 PM
whitequark committed rL342434: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
[LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices
Sep 17 2018, 6:51 PM
whitequark closed D52206: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
Sep 17 2018, 6:51 PM
whitequark committed rL342433: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
[OCaml] Add OCaml APIs for Invoke arguments and destinations
Sep 17 2018, 6:51 PM
whitequark closed D52204: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
Sep 17 2018, 6:51 PM
whitequark accepted D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:47 PM
whitequark accepted D52215: [NFC][OCaml] Fix copy paste error in file header.
Sep 17 2018, 6:47 PM
whitequark accepted D52214: [NFC][OCaml] Fix implicit declaration compilation warnings.
Sep 17 2018, 6:46 PM
whitequark requested changes to D52213: [OCaml] Add OCaml API for __cxa_demangle.

I'm not sure if this function has a place here. It's not a function provided by the LLVM API, and it's platform-specific. I think with this change it would not be possible to build the OCaml bindings under MSVC, for example.

Sep 17 2018, 6:46 PM
whitequark requested changes to D52212: [LLVM-C][OCaml] Add UnifyFunctionExitNodes pass to C and OCaml APIs.
Sep 17 2018, 6:44 PM
whitequark added inline comments to D52211: [LLVM-C][OCaml] Add LowerAtomic pass to C and OCaml APIs.
Sep 17 2018, 6:44 PM
whitequark requested changes to D52210: [LLVM-C] Add C APIs to access DebugLoc info.

Why are there three sets of functions that all operate on LLVMValueRef? Can't we make it a single set of functions?

Sep 17 2018, 6:42 PM
whitequark accepted D52209: [LLVM-C][OCaml] Add C and OCaml APIs for llvm::StructType::isLiteral.
Sep 17 2018, 6:39 PM
whitequark requested changes to D52208: [OCaml] Add OCaml APIs for LLVMGetModuleDataLayout and LLVMABISizeOfType.

There is already an Llvm_target.DataLayout.t, we don't need to wrap it the second time.

Sep 17 2018, 6:39 PM
whitequark added inline comments to D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 17 2018, 6:38 PM
whitequark added inline comments to D52207: [OCaml] Add OCaml API for LLVMGetIndices.
Sep 17 2018, 6:38 PM
whitequark accepted D52206: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices.
Sep 17 2018, 6:34 PM
whitequark added inline comments to D52205: [OCaml] Add OCaml API for LLVMIsCleanup.
Sep 17 2018, 6:34 PM
whitequark accepted D52204: [OCaml] Add OCaml APIs for Invoke arguments and destinations.
Sep 17 2018, 6:32 PM
whitequark committed rL342429: [OCaml] Add GlobalIFunc value kind to OCaml API.
[OCaml] Add GlobalIFunc value kind to OCaml API
Sep 17 2018, 5:04 PM
whitequark committed rL342428: [OCaml] Add Token type to kind enum in OCaml API.
[OCaml] Add Token type to kind enum in OCaml API
Sep 17 2018, 5:04 PM
whitequark closed D52198: [OCaml] Add GlobalIFunc value kind to OCaml API.
Sep 17 2018, 5:03 PM
whitequark closed D52197: [OCaml] Add Token type to kind enum in OCaml API.
Sep 17 2018, 5:03 PM
whitequark committed rL342427: [OCaml] Add missing instruction opcodes to OCaml API.
[OCaml] Add missing instruction opcodes to OCaml API
Sep 17 2018, 5:03 PM
whitequark closed D52196: [OCaml] Add missing instruction opcodes to OCaml API.
Sep 17 2018, 5:03 PM
whitequark accepted D52198: [OCaml] Add GlobalIFunc value kind to OCaml API.

LGTM

Sep 17 2018, 4:47 PM
whitequark accepted D52197: [OCaml] Add Token type to kind enum in OCaml API.

LGTM

Sep 17 2018, 4:46 PM
whitequark accepted D52196: [OCaml] Add missing instruction opcodes to OCaml API.

Thanks!

Sep 17 2018, 4:19 PM

Sep 15 2018

whitequark accepted D51642: [LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints.

LGTM

Sep 15 2018, 12:02 AM

Aug 30 2018

whitequark added inline comments to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 30 2018, 10:17 PM
whitequark added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

How is a user of this API supposed to map the unsigned Kind values to something meaningful? We don't have an enum LLVMMetadataKind, do we?

Aug 30 2018, 5:07 PM
whitequark accepted D47179: [LLVM-C] Add Bindings For Named Metadata.

LGTM

Aug 30 2018, 9:51 AM

Aug 19 2018

whitequark committed rL340148: [bindings/go] Add coroutine passes.
[bindings/go] Add coroutine passes
Aug 19 2018, 4:41 PM
whitequark closed D50951: [bindings/go] Add coroutine passes.
Aug 19 2018, 4:40 PM
whitequark committed rL340147: [LLVM-C] Add coroutine passes.
[LLVM-C] Add coroutine passes
Aug 19 2018, 4:40 PM
whitequark closed D50950: [LLVM-C] Add coroutine passes.
Aug 19 2018, 4:40 PM
whitequark committed rL340146: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
[C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType
Aug 19 2018, 4:40 PM
whitequark closed D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
Aug 19 2018, 4:40 PM
whitequark accepted D50951: [bindings/go] Add coroutine passes.
Aug 19 2018, 4:38 PM
whitequark accepted D50950: [LLVM-C] Add coroutine passes.
Aug 19 2018, 3:53 PM

Aug 15 2018

whitequark accepted D47684: [bindings/go] Add Go bindings to the Token type.
Aug 15 2018, 11:40 PM
whitequark accepted D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
Aug 15 2018, 11:39 PM