Page MenuHomePhabricator

[clang] Get rid of "%T" expansions
ClosedPublic

Authored by kubamracek on Aug 7 2017, 5:15 PM.

Details

Summary

The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.

This patch removes %T in clang.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Aug 7 2017, 5:15 PM
rjmccall accepted this revision.Aug 7 2017, 5:16 PM

Seems reasonable to me.

This revision is now accepted and ready to land.Aug 7 2017, 5:16 PM
rnk accepted this revision.Aug 8 2017, 10:18 AM

Thanks, most of these looks like potential races between tests waiting to happen.

This revision was automatically updated to reflect the committed changes.