This is an archive of the discontinued LLVM Phabricator instance.

Add NetBSD support in asan_stack.h
ClosedPublic

Authored by krytarowski on Aug 6 2017, 6:53 AM.

Details

Summary

Part of the code inspired by the original work on libsanitizer in GCC 5.4 by Christos Zoulas.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Aug 6 2017, 6:53 AM
davide added a subscriber: davide.Aug 6 2017, 5:51 PM

Kamil, a fair amount of these changes seem to just replace SANITIZER_FREEBSD with SANITIZER_FREEBSD || SANITIZER_NETBSD.
I wonder whether it makes sense to define a SANITIZER_BSD macro for both of them?

Also, what's the difference in support you expect between NetBSD and FreeBSD to support sanitizers?

Kamil, a fair amount of these changes seem to just replace SANITIZER_FREEBSD with SANITIZER_FREEBSD || SANITIZER_NETBSD.
I wonder whether it makes sense to define a SANITIZER_BSD macro for both of them?

Also, what's the difference in support you expect between NetBSD and FreeBSD to support sanitizers?

I oppose SANITIZER_BSD as I don't intend to test BSD/OS and similar systems.

FreeBSD and NetBSD are sufficiently distinct to be managed separately. Also there will certainly come at some point OpenBSD, which
is different than FreeBSD and NetBSD. I don't have access to other BSDs to test potential patches.

Solaris support as far as I recall, was very similar, mostly adding || SANITIZER_SOLARIS to existing code.

vitalybuka accepted this revision.Aug 7 2017, 4:00 PM
This revision is now accepted and ready to land.Aug 7 2017, 4:00 PM
krytarowski closed this revision.Aug 7 2017, 4:35 PM