This is an archive of the discontinued LLVM Phabricator instance.

[clang] Add ARM64 support to armintr.h for MSVC compatibility
ClosedPublic

Authored by mgrang on Jul 25 2017, 3:55 PM.

Diff Detail

Event Timeline

mgrang created this revision.Jul 25 2017, 3:55 PM
mstorsjo edited edge metadata.Jul 25 2017, 8:27 PM

The Microsoft version of intrin.h includes a header named arm64intr.h (IIRC), I think it'd be better for compatibility if we also provided a file with the same name instead of reusing this one.

compnerd accepted this revision.Jul 25 2017, 8:37 PM

Please split this out into arm64intr.h and include it from intrin.h under a #if defined(_M_ARM64) case before committing.

This revision is now accepted and ready to land.Jul 25 2017, 8:37 PM
mgrang updated this revision to Diff 108208.Jul 25 2017, 9:18 PM

Patch updated as per comments.

mstorsjo accepted this revision.Jul 25 2017, 9:33 PM
compnerd accepted this revision.Jul 25 2017, 9:37 PM
This revision was automatically updated to reflect the committed changes.