This patch adds handling of the LoopExit CFGElements to the StaticAnalyzer.
This is reached by introducing a new ProgramPoint.
Details
Diff Detail
Event Timeline
Looks good to me! (Please expand the comment, though.)
include/clang/Analysis/ProgramPoint.h | ||
---|---|---|
658 | My recommendation would be to think about it from the perspective of someone new to the codebase trying to understand when the analyzer will reach such a program point. What additional context will they need that is not conveyed in the name alone? At a minimum, I think it is worth mentioning that a LoopExit point can arise even when a loop is not entered and that not all loop exits will result in a LoopExit program point. |
Also, please mention in the commit message that tests will be added in a following commit.
Can you add a comment explaining what meaning of this program point is.