This is an archive of the discontinued LLVM Phabricator instance.

Differential D35493

[AArch64] Use 16 bytes as preferred function alignment on Cortex-A73.
ClosedPublic

Authored by fhahn on Jul 17 2017, 9:54 AM.

Details

Reviewers
mcrosier
t.p.northover
aadg
silviu.baranga
Commits
rG3530094de6ef: [AArch64] Use 16 bytes as preferred function alignment on Cortex-A73.
rL308283: [AArch64] Use 16 bytes as preferred function alignment on Cortex-A73.
Summary

Using 16 byte alignment is beneficial on Cortex-A73, similar to
Cortex-A72 (added in D34961).

Diff Detail

Event Timeline

fhahn created this revision.Jul 17 2017, 9:54 AM
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. · View Herald TranscriptJul 17 2017, 9:55 AM
t.p.northover accepted this revision.Jul 17 2017, 10:12 AM

Looks fine to me.

This revision is now accepted and ready to land.Jul 17 2017, 10:12 AM
fhahn closed this revision.Jul 18 2017, 2:31 AM

Revision Contents

PathSize
lib/
Target/
AArch64/
4 lines
test/
CodeGen/
AArch64/
2 lines

Diff 106893

lib/Target/AArch64/AArch64Subtarget.cpp

Show First 20 Lines • Show All 128 Lines • ▼ Show 20 Lines case ThunderXT83:
// FIXME: remove this to enable 64-bit SLP if performance looks good. // FIXME: remove this to enable 64-bit SLP if performance looks good.
MinVectorRegisterBitWidth = 128; MinVectorRegisterBitWidth = 128;
break; break;
case CortexA35: break; case CortexA35: break;
case CortexA53: break; case CortexA53: break;
case CortexA72: case CortexA72:
PrefFunctionAlignment = 4; PrefFunctionAlignment = 4;
break; break;
case CortexA73: break; case CortexA73:
PrefFunctionAlignment = 4;
break;
case Others: break; case Others: break;
} }
} }
#ifdef LLVM_BUILD_GLOBAL_ISEL #ifdef LLVM_BUILD_GLOBAL_ISEL
namespace { namespace {
struct AArch64GISelActualAccessor : public GISelAccessor { struct AArch64GISelActualAccessor : public GISelAccessor {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines

test/CodeGen/AArch64/preferred-function-alignment.ll

; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=generic < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=generic < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a35 < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a35 < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a53 < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a53 < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a73 < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cyclone < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cyclone < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=falkor < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=falkor < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=kryo < %s | FileCheck --check-prefix=ALIGN2 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=kryo < %s | FileCheck --check-prefix=ALIGN2 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderx < %s | FileCheck --check-prefix=ALIGN3 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderx < %s | FileCheck --check-prefix=ALIGN3 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt81 < %s | FileCheck --check-prefix=ALIGN3 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt81 < %s | FileCheck --check-prefix=ALIGN3 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt83 < %s | FileCheck --check-prefix=ALIGN3 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt83 < %s | FileCheck --check-prefix=ALIGN3 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt88 < %s | FileCheck --check-prefix=ALIGN3 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderxt88 < %s | FileCheck --check-prefix=ALIGN3 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderx2t99 < %s | FileCheck --check-prefix=ALIGN3 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=thunderx2t99 < %s | FileCheck --check-prefix=ALIGN3 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a57 < %s | FileCheck --check-prefix=ALIGN4 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a57 < %s | FileCheck --check-prefix=ALIGN4 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a72 < %s | FileCheck --check-prefix=ALIGN4 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a72 < %s | FileCheck --check-prefix=ALIGN4 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=cortex-a73 < %s | FileCheck --check-prefix=ALIGN4 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m1 < %s | FileCheck --check-prefix=ALIGN4 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m1 < %s | FileCheck --check-prefix=ALIGN4 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m2 < %s | FileCheck --check-prefix=ALIGN4 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m2 < %s | FileCheck --check-prefix=ALIGN4 %s
; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m3 < %s | FileCheck --check-prefix=ALIGN4 %s ; RUN: llc -mtriple=aarch64-unknown-linux -mcpu=exynos-m3 < %s | FileCheck --check-prefix=ALIGN4 %s
define void @test() { define void @test() {
ret void ret void
} }
; CHECK-LABEL: test ; CHECK-LABEL: test
; ALIGN2: .p2align 2 ; ALIGN2: .p2align 2
; ALIGN3: .p2align 3 ; ALIGN3: .p2align 3
; ALIGN4: .p2align 4 ; ALIGN4: .p2align 4