Page MenuHomePhabricator

silviu.baranga (Silviu Baranga)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 8 2013, 6:33 AM (293 w, 3 d)

Recent Activity

Nov 2 2017

silviu.baranga added a comment to D38785: [LV/LAA] Avoid specializing a loop for stride=1 when this predicate implies a single-iteration loop.

Yes, I agree as well.

Nov 2 2017, 11:58 PM
silviu.baranga added a comment to D38785: [LV/LAA] Avoid specializing a loop for stride=1 when this predicate implies a single-iteration loop.

I agree that this a strict improvement.

Nov 2 2017, 3:07 AM

Oct 11 2017

silviu.baranga added a comment to D38785: [LV/LAA] Avoid specializing a loop for stride=1 when this predicate implies a single-iteration loop.

It sounds like this is a profitability issue and therefore the LAA users should handle this? Maybe the users would also want to be more general (I think a loop with an iteration count of 2 is probably not worth vectorizing).

Oct 11 2017, 1:39 AM

Sep 2 2015

silviu.baranga added a comment to D12559: Fix IRBuilder CreateBitOrPointerCast for vector types.

Thanks for the reduced testcase!

Sep 2 2015, 3:51 PM

Aug 2 2014

silviu.baranga added a comment to D4367: Review for machine combiner pass.

Thanks! LGTM

Aug 2 2014, 7:26 AM

Jul 31 2014

silviu.baranga added a comment to D4367: Review for machine combiner pass.

Thanks, this all makes sense to me. However, I think there is still an issue with the default
AArch64 target.

Jul 31 2014, 12:40 PM

Jul 30 2014

silviu.baranga added a comment to D4367: Review for machine combiner pass.

Hi Gerolf,

Jul 30 2014, 2:35 PM

Jul 27 2014

silviu.baranga added inline comments to D4367: Review for machine combiner pass.
Jul 27 2014, 6:22 PM
silviu.baranga added a comment to D4367: Review for machine combiner pass.

Looks like I spoke too soon (new comment inlined). I think there are some issues with targets without a machine model.

Jul 27 2014, 4:18 PM

Jul 25 2014

silviu.baranga added a comment to D4367: Review for machine combiner pass.

Ah, I just noticed that a header file is missing (AArch64MachineCombinerPattern.h).

Jul 25 2014, 5:40 PM

Jul 18 2014

silviu.baranga added a comment to D4367: Review for machine combiner pass.

Just some minor issues that I've noticed (comments inlined). Otherwise looks good.

Jul 18 2014, 5:27 PM

Jul 10 2014

silviu.baranga added a comment to D4438: [AArch64] Lower sdiv x, pow2 using add + select + shift..

It seems to me that the branch mispredict cost for the case where the values of X are random would outweigh the benefits of this transformation for your alternative code sequence, even on OoO cores.

Jul 10 2014, 3:26 AM

Jul 9 2014

silviu.baranga updated subscribers of D4438: [AArch64] Lower sdiv x, pow2 using add + select + shift..
Jul 9 2014, 11:15 AM

Jul 6 2014

silviu.baranga added inline comments to D4367: Review for machine combiner pass.
Jul 6 2014, 5:57 AM
silviu.baranga added a comment to D4367: Review for machine combiner pass.

Hi Gerolf,

Jul 6 2014, 5:53 AM
silviu.baranga updated subscribers of D4367: Review for machine combiner pass.
Jul 6 2014, 3:22 AM