Page MenuHomePhabricator

[Polly] [PPCGCodeGeneration] Enable GPU code generation with invariant loads.
ClosedPublic

Authored by bollu on Jun 25 2017, 6:53 AM.

Details

Summary

The condition that disallowed code generation in PPCGCodeGeneration with
invariant loads is not required. I haven't been able to construct a
counterexample where this generates invalid code.

Event Timeline

bollu created this revision.Jun 25 2017, 6:53 AM
grosser accepted this revision.Jun 25 2017, 7:18 AM

LGTM.

This revision is now accepted and ready to land.Jun 25 2017, 7:18 AM
bollu closed this revision.Jun 26 2017, 12:50 AM

Closed by commit r306245. For some reason, Phab did not auto-close this, even though commit contains:

Differential Revision: https://reviews.llvm.org/D34604

@grosser thanks for the fix with REQUIRES: pollyacc. I missed it :)

Why wasn't it supported previously ?

We started with a minimal set of features and then enabled more and more as we found time to test them.