[ThinLTO] Add dump-summary command to llvm-lto2 tool

[ncharlie]

Summary

[ThinLTO] Add dump-summary command to llvm-lto2 tool

Adds command to dump ThinLTO module summaries in YAML to the llvm-lto2 tool.

[tejohnson]

test/tools/llvm-lto2/X86/dump-summary.ll

3

Rather than repeating this command and piping through egrep, you should run once and pipe through FileCheck (see the other tests in this directory for examples). I.e. pipe through "FileCheck %s", then have several lines prefixed by "CHECK: " to look for the expected output. E.g.:

CHECK: NotEligibleToImport: false

[ncharlie]

Use FileCheck rather than egrep

[ncharlie]

test/tools/llvm-lto2/X86/dump-summary.ll

3

Oh, cool - I saw FileCheck before, but assumed that the 'CHECK' lines had to be outputted throughout the pipeline and couldn't be fed into FileCheck like that. I fixed it.

[davide]

Minor comment, LGTM with that (once your other patch goes in).

tools/llvm-lto2/llvm-lto2.cpp

356–367

Add a comment to this function.

[ncharlie]

Added comment.

[davide]

Teresa, any further comments or we can go ahead and commit Charles' patch?

[davide]

Please hold the press on this one for a bit.
I didn't see @chandlerc / @dblaikie comments on the RFC and they seem to not have been fully addressed.
I guess you may want to continue the discussion there before coming back to this.