ncharlie (Charles Saternos)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2017, 2:45 PM (11 w, 4 h)

Recent Activity

Today

ncharlie added a comment to D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.

Just a note: this isn't fully completed yet. I still have to add tests and do some verification, but I wanted to make it's on the right track.

Thu, Jul 20, 12:20 PM
ncharlie added a comment to D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.

refactored code and removed unnecessary SCCNodes

Thu, Jul 20, 11:09 AM
ncharlie updated the diff for D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.
  • added memory access info to index callgraph edges
  • renamed functions
Thu, Jul 20, 11:09 AM
ncharlie added inline comments to D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.
Thu, Jul 20, 7:31 AM

Yesterday

ncharlie added inline comments to D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.
Wed, Jul 19, 1:57 PM
ncharlie created D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO.
Wed, Jul 19, 10:09 AM

Mon, Jul 17

ncharlie added a comment to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

@dexonsmith @pcc any updates on this?

Mon, Jul 17, 6:15 AM · lld

Tue, Jun 27

ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Applied D34080

Tue, Jun 27, 9:30 AM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Added names to dump-summary in llvm-lto2.

Tue, Jun 27, 8:38 AM
ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Tue, Jun 27, 8:14 AM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.
Tue, Jun 27, 8:10 AM

Mon, Jun 26

ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.
Mon, Jun 26, 7:52 AM

Jun 20 2017

ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Updated GlobalValue loop.

Jun 20 2017, 1:35 PM
ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 20 2017, 9:19 AM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

formatting

Jun 20 2017, 9:18 AM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Added test, further cleanup.

Jun 20 2017, 9:15 AM
ncharlie added a comment to D34063: [ThinLTO] YAML traits for module summaries.

Can you add some test cases?

Jun 20 2017, 6:10 AM

Jun 19 2017

ncharlie updated the diff for D34080: [ThinLTO] Add dump-summary command to llvm-lto2 tool.

Added comment.

Jun 19 2017, 5:31 AM
ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Simplified test.

Jun 19 2017, 5:27 AM · lld

Jun 16 2017

ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Fixes according to comments.

Jun 16 2017, 7:38 AM

Jun 15 2017

ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 15 2017, 6:19 AM

Jun 13 2017

ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 13 2017, 1:01 PM
ncharlie retitled D34063: [ThinLTO] YAML traits for module summaries from [ThinLTO][llvm-lto2] Dump YAML for module summaries to [ThinLTO] YAML traits for module summaries.
Jun 13 2017, 7:22 AM

Jun 12 2017

ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 12 2017, 1:13 PM
ncharlie added inline comments to D34080: [ThinLTO] Add dump-summary command to llvm-lto2 tool.
Jun 12 2017, 12:22 PM
ncharlie updated the diff for D34080: [ThinLTO] Add dump-summary command to llvm-lto2 tool.

Use FileCheck rather than egrep

Jun 12 2017, 12:21 PM

Jun 10 2017

ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Removed extraneous formatting.

Jun 10 2017, 8:08 AM · lld
ncharlie created D34080: [ThinLTO] Add dump-summary command to llvm-lto2 tool.
Jun 10 2017, 7:47 AM
ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 10 2017, 6:04 AM

Jun 9 2017

ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 9 2017, 4:02 PM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Addressed some updates from the comments.

Jun 9 2017, 4:00 PM
ncharlie added a comment to D34063: [ThinLTO] YAML traits for module summaries.
In D34063#777137, @pcc wrote:

Can you split this into two patches (both with their own tests), one which adds the subcommand and the other which adds the new YAML output?

Jun 9 2017, 1:14 PM
ncharlie added inline comments to D34063: [ThinLTO] YAML traits for module summaries.
Jun 9 2017, 1:06 PM
ncharlie updated the diff for D34063: [ThinLTO] YAML traits for module summaries.

Oops - got rid of old llvm-dis code.

Jun 9 2017, 1:02 PM
ncharlie created D34063: [ThinLTO] YAML traits for module summaries.
Jun 9 2017, 12:57 PM

Jun 5 2017

ncharlie added a comment to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Addressed comments. Formatted with clang-format, so that's why there are so many extra changes in the diff.

Jun 5 2017, 8:10 AM · lld
ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.
  • Added hidden "set-importing" flag to llvm-dis to set the IsImporting boolean for testing.
  • Ran clang-format
  • Added comment
  • Smaller test
Jun 5 2017, 8:08 AM · lld

May 29 2017

ncharlie added inline comments to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.
May 29 2017, 11:36 AM · lld
ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Added context

May 29 2017, 10:26 AM · lld
ncharlie added a comment to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

@pcc @mehdi_amini I've simplified the tests using your recommendations. Note that to get lazy loading to work with llvm-dis, I had to set the IsImporting bool to true - I'm not sure if this is correct, but I couldn't set the value to true otherwise. Should I add a flag to allow enabling/disabling it instead of hardcoding it?

May 29 2017, 9:52 AM · lld
ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Simplified test

May 29 2017, 9:50 AM · lld

May 26 2017

ncharlie added inline comments to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.
May 26 2017, 8:56 AM · lld
ncharlie updated the diff for D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

fixed tests

May 26 2017, 8:54 AM · lld

May 25 2017

ncharlie added a comment to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

Thanks for your first contribution, great GSoC start!

Thanks! This was a good chance to look closely at the code to start learning how it works.

One note: this manifests with ThinLTO, but it might be a more generic metadata issue. Are you able to reproduce without ThinLTO (and maybe with a single file?)

The bug only happens when lazy loading Metadata. Lazy loading occurs when module level metadata is being imported by ThinLTO (see https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp;303885$781). I believe this is the only path that leads to lazy loading, so I don't think it can happen elsewhere.

May 25 2017, 10:35 AM · lld

May 24 2017

ncharlie created D33513: [ThinLTO] Fix ThinLTO crash while destroying context.
May 24 2017, 11:40 AM · lld