Page MenuHomePhabricator

[GlobalISel][X86] Support vector type G_EXTRACT selection.
ClosedPublic

Authored by igorb on Jun 6 2017, 1:52 PM.

Details

Summary

Support vector type G_EXTRACT selection. For now G_EXTRACT marked as legal for any type, so nothing to do in legalizer.
Split from https://reviews.llvm.org/D33665

Event Timeline

igorb created this revision.Jun 6 2017, 1:52 PM
guyblank added inline comments.Jun 22 2017, 3:46 AM
lib/Target/X86/X86InstructionSelector.cpp
706

does it make sense not to give up here?

not sure when the emit would fail, but we could try to generate a vextract instead.

717
if(..)
  return false;
igorb updated this revision to Diff 103575.Jun 22 2017, 7:34 AM
  • rebase
lib/Target/X86/X86InstructionSelector.cpp
706

I can't test case when the emit fail , so i prefare to give up

717

I think in this case it will complicate the code

This revision is now accepted and ready to land.Jun 25 2017, 1:45 AM
This revision was automatically updated to reflect the committed changes.