Support vector type G_UNMERGE_VALUES selection.
For now G_UNMERGE_VALUES marked as legal for any type, so nothing to do in legalizer.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Hi Igor,
It seems to me that the patch could be split into finer grain patches.
- API change (getRegClassForTypeOnBank to getRegClass)
- One change for each different select (unmerge, merge, copy, etc.)
- Legality setting
Please use the .mir framework to test separately each new thing (like one test for the legality change, one for the select part). Of course bitcode to asm are still useful as integration tests and should be kept.
Cheers,
-Quentin
Comment Actions
Split the patch according to Quentin comment.
https://reviews.llvm.org/D33958
https://reviews.llvm.org/D33957
https://reviews.llvm.org/D33956
https://reviews.llvm.org/D33952
Thanks.