Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D33626

[GlobalISel] combine not symmetric merge/unmerge nodes.
ClosedPublic
Actions

Authored by igorb on May 28 2017, 12:10 AM.

Details

Reviewers
t.p.northover
qcolombet
zvi
rovka
Commits
rG14535f0fc297: [GlobalISel] combine not symmetric merge/unmerge nodes.
rL305783: [GlobalISel] combine not symmetric merge/unmerge nodes.
Summary

In some cases legalization ends up with not symmetric merge/unmerge nodes.
Transform it to merge/unmerge nodes.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb created this revision.May 28 2017, 12:10 AM
Herald added subscribers: kristof.beyls, rovka. · View Herald TranscriptMay 28 2017, 12:10 AM
igorb added a child revision: D33665: [GlobalISel][X86] Support vector type G_UNMERGE_VALUES selection..May 29 2017, 10:54 PM
igorb added a comment.Jun 7 2017, 9:49 AM

ping

igorb added a comment.Jun 18 2017, 2:25 AM

ping

igorb added a reviewer: rovka.Jun 18 2017, 2:26 AM
t.p.northover accepted this revision.Jun 19 2017, 9:11 AM

This looks reasonable to me.

This revision is now accepted and ready to land.Jun 19 2017, 9:11 AM
igorb added a comment.Jun 19 2017, 9:53 AM

Thanks for the review!

Closed by commit rL305783: [GlobalISel] combine not symmetric merge/unmerge nodes. (authored by ibreger). · Explain WhyJun 20 2017, 1:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
CodeGen/
GlobalISel/
2 lines
lib/
CodeGen/
GlobalISel/
71 lines
test/
CodeGen/
X86/
GlobalISel/
12 lines

Diff 103175

View Options

llvm/trunk/include/llvm/CodeGen/GlobalISel/Legalizer.h

Loading...
View Options

llvm/trunk/lib/CodeGen/GlobalISel/Legalizer.cpp

Loading...
View Options

llvm/trunk/test/CodeGen/X86/GlobalISel/legalize-add-v512.mir

Loading...