This is an archive of the discontinued LLVM Phabricator instance.

Differential D33217

[libunwind] Fix executable stack directive on Linux.
ClosedPublic

Authored by manojgupta on May 15 2017, 3:23 PM.

Details

Reviewers
phosek
compnerd
rs
rmaprath
EricWF
krytarowski
Commits
rG2cbfd2506ab8: [libunwind] Fix executable stack directive on Linux.
rUNW303206: [libunwind] Fix executable stack directive on Linux.
rL303206: [libunwind] Fix executable stack directive on Linux.
Summary

Disable executable stack on Linux. Also remove redundant Android check
as it is covered by Android.

Diff Detail

Event Timeline

manojgupta created this revision.May 15 2017, 3:23 PM
Herald added subscribers: krytarowski, srhines. · View Herald TranscriptMay 15 2017, 3:23 PM
krytarowski added a comment.May 15 2017, 3:39 PM

I think this should check for GNU platforms, not GNU compatible compilers. As far as I understand we don't want this on NetBSD in both cases libunwind, llvm.

krytarowski requested changes to this revision.May 15 2017, 3:45 PM

__GNU__ is not for GCC but for GNU/Hurd.

This revision now requires changes to proceed.May 15 2017, 3:45 PM
manojgupta updated this revision to Diff 99073.May 15 2017, 3:49 PM
manojgupta edited edge metadata.

Use linux to disable executable for linux.

manojgupta updated this revision to Diff 99081.May 15 2017, 4:15 PM

Removed redundant check for Android since linux should cover it.

krytarowski added a comment.May 15 2017, 4:22 PM

From the NetBSD point of view looks good.

manojgupta retitled this revision from [libunwind] Fix a check from __GNU__ to __GNUC__ for disabling executable stack. to [libunwind] Fix executable stack directive on Linux..May 15 2017, 4:24 PM
manojgupta edited the summary of this revision. (Show Details)
phosek edited edge metadata.May 15 2017, 4:43 PM

This is no longer needed on Fuchsia so we may as well take it out, but I'm also happy to send a separate change for that.

manojgupta added a comment.May 16 2017, 11:54 AM

Is any further change required or can I submit it now?

krytarowski accepted this revision.May 16 2017, 12:56 PM
This revision is now accepted and ready to land.May 16 2017, 12:56 PM
manojgupta closed this revision.May 16 2017, 1:32 PM

Revision Contents

PathSize
src/
2 lines

Diff 99073

src/assembly.h

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#if defined(__arm__) #if defined(__arm__)
#define SYMBOL_IS_FUNC(name) .type name,%function #define SYMBOL_IS_FUNC(name) .type name,%function
#else #else
#define SYMBOL_IS_FUNC(name) .type name,@function #define SYMBOL_IS_FUNC(name) .type name,@function
#endif #endif
#if defined(__GNU__) || defined(__ANDROID__) || defined(__FreeBSD__) || \ #if defined(__GNU__) || defined(__ANDROID__) || defined(__FreeBSD__) || \
defined(__Fuchsia__) defined(__Fuchsia__) || defined(__linux__)
#define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits #define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits
#else #else
#define NO_EXEC_STACK_DIRECTIVE #define NO_EXEC_STACK_DIRECTIVE
#endif #endif
#else #else
#define SYMBOL_IS_FUNC(name) \ #define SYMBOL_IS_FUNC(name) \
Show All 37 Lines