- User Since
- May 27 2014, 1:41 AM (288 w, 6 d)
Apr 24 2017
Looks like I'm the only one interested in this - abandoning.
Apr 12 2017
Apologies for the delay in replying to this.
Apr 4 2017
Addressed review comments from @EricWF .
Mar 21 2017
Fixed a few paths.
Mar 14 2017
Mar 2 2017
Thanks for these patches!
Mar 1 2017
Feb 28 2017
Fixed minor omission.
Feb 24 2017
Perhaps change config.h and remove the definition there and adjust other places accordingly?
Different approach: Externalize these functions only for the external-thread-api library variant.
Different take on the patch: Externalize this function only for the externally-thread-api variant.
Feb 23 2017
Committed as r295963.
Updated to address comments from @rengolin.
Feb 15 2017
I've raised PR31966 to poke this :)
Feb 13 2017
Re-based on trunk.
Addressing review comments: Get rid of the tab characters.
Address review comments: Get rid of the unnecessary pass id definition in the llvm namespace.
Feb 10 2017
Feb 9 2017
Feb 8 2017
Sorry for the delay, I've updated the patch with all the comments addressed.
Feb 7 2017
Abandoning - forgot cfe-commits....
Jan 24 2017
Sorry, I meant -DLIBCXX_ENABLE_ASSERTIONS=ON.
@EricWF: My downstream builds have -DLLVM_ENABLE_ASSERTIONS=ON by default and they are showing some failures after this commit. Log attached:
Jan 12 2017
Jan 5 2017
This is much better (few nits inline). And many thanks for the docs update (btw, do those docs updates land on some web URL automagically when committed?).
Jan 4 2017
Jan 3 2017
I will commit this now to get the testing working again. Thought of putting up the patch for review in case if there is a better way to do this.
Dec 30 2016
Most of this is no longer needed. I'll submit patches for the parts that are actually needed (e.g. nanosleep) later on. Thanks.
Dec 29 2016
Dec 19 2016
Dec 15 2016
Dec 12 2016
Patch updated with more context.
Dec 8 2016
Abandoning as this has been replaced with D27575.
Dec 5 2016
Nov 29 2016
Nov 19 2016
On the other hand, disabling <exception> would mean disabling some parts of the library as well (in this case, std::promise::set_exception). Perhaps that's a bad path to follow. Not sure.
Nov 9 2016
Not sure if either of these tests add much value to the no-exceptions variant, using std::nested_exception with such a library seem pointless to me. Perhaps marking these as UNSUPPORTED is a better fix?
Nov 6 2016
Nov 2 2016
Would it be more cleaner to separate out the exceptions-related tests into their own functions? So, we'd have the two functions test_withexceptions() and test_noexceptions(); the former will only be invoked when testing the normal library variant, the latter will be invoked for all the library variants.
Oct 31 2016
Oct 30 2016
This looks sensible to me. I'll let @EricWF approve.
Oct 23 2016
Oct 14 2016
Committed as r284128.
Oct 13 2016
@EricWF: Gentle ping.
Patch re-based on the latest trunk.
Oct 12 2016
Oct 11 2016
Added some comments to @EricWF's feedback. Will check back tomorrow (falling asleep...)
Oct 10 2016
Committed as r283726.