Add missing FileCheck, update CHECK lines and avoid subshell

[• rafael]

Summary

I noticed that this file had CHECK lines but no FileCheck run.

[filcab]

Adding mpividori as he's been doing a bunch of stuff in sancov recently. I'm not sure what we're expecting from the test (especially the disappearance of PCs in the ChildPID cov file)

[• rafael]

ping

[rnk]

Looks like this was missing since @eugenis added it in rL210180.

There should be some non-zero number of PCs from the child process, these globs should pick up two ${pid}.sancov.raw files and unpack them to ${pid}.sancov.

[eugenis]

Right, there should be PCs in the child .sancov.
Are they missing now? Sounds like a regression.
@kcc has rewritten this part of the code a few times since I've last looked.

[rnk]

compiler-rt/test/asan/TestCases/Posix/coverage-fork-direct.cc

39 ↗

(On Diff #93257)

Let's commit this with a CHECKX: and a FIXME to bring back the child pcs.

[• rafael]

Add FIXME.

[• rafael]

Actually disable the second check.

[• rafael]

So, is the last version with the FIXME OK?

[rnk]

Yep, looks good. I missed the XCHECK update.

[• rafael]

r301541

test/asan/TestCases/Posix/coverage-fork-direct.cc

 // RUN: %clangxx_asan -fsanitize-coverage=func %s -o %t
 // RUN: rm -rf %T/coverage-fork-direct
 // RUN: mkdir -p %T/coverage-fork-direct && cd %T/coverage-fork-direct
-// RUN: (%env_asan_opts=coverage=1:coverage_direct=1:verbosity=1 %run %t; \
-// RUN:  %sancov rawunpack *.sancov.raw; %sancov print *.sancov) 2>&1
+// RUN: %env_asan_opts=coverage=1:coverage_direct=1:verbosity=1 %run %t > %t.log 2>&1
+// RUN: %sancov rawunpack *.sancov.raw
+// RUN: %sancov print *.sancov >> %t.log 2>&1
+// RUN: FileCheck %s < %t.log
 //
 // XFAIL: android
 
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>
 
 __attribute__((noinline))
if (child_pid == 0) {
     foo();
     bar();
   }
   return 0;
 }
 
 // CHECK-DAG: Child PID: [[ChildPID:[0-9]+]]
 // CHECK-DAG: Parent PID: [[ParentPID:[0-9]+]]
-// CHECK-DAG: read 3 PCs from {{.*}}.[[ParentPID]].sancov
-// CHECK-DAG: read 1 PCs from {{.*}}.[[ChildPID]].sancov
+// CHECK-DAG: read 3 64-bit PCs from {{.*}}.[[ParentPID]].sancov
+
+// FIXME: this is missing
+// XCHECK-DAG: read 1 64-bit PCs from {{.*}}.[[ChildPID]].sancov