Page MenuHomePhabricator

mpividori (Marcos Pividori)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 21 2016, 8:52 PM (143 w, 2 d)

Recent Activity

Feb 10 2017

mpividori committed rL294769: [libFuzzer] Use stoull instead of stol to ensure 64 bits..
[libFuzzer] Use stoull instead of stol to ensure 64 bits.
Feb 10 2017, 10:55 AM
mpividori closed D29831: [libFuzzer] Use long long to ensure 64 bits. by committing rL294769: [libFuzzer] Use stoull instead of stol to ensure 64 bits..
Feb 10 2017, 10:55 AM
mpividori added a comment to D29831: [libFuzzer] Use long long to ensure 64 bits..

@zturner Ok. I agree.

Feb 10 2017, 10:30 AM
mpividori created D29831: [libFuzzer] Use long long to ensure 64 bits..
Feb 10 2017, 9:20 AM

Feb 9 2017

mpividori committed rL294724: Escape percent sign..
Escape percent sign.
Feb 9 2017, 11:22 PM
mpividori committed rL294688: [libFuzzer] Export external functions on tests..
[libFuzzer] Export external functions on tests.
Feb 9 2017, 5:51 PM
mpividori closed D29752: [libFuzzer] Export external functions. by committing rL294688: [libFuzzer] Export external functions on tests..
Feb 9 2017, 5:51 PM
mpividori committed rL294687: [libFuzzer] Use dynamic loading for External Functions on Windows..
[libFuzzer] Use dynamic loading for External Functions on Windows.
Feb 9 2017, 5:47 PM
mpividori closed D29751: [libFuzzer] Use dynamic loading for External Functions on Windows. by committing rL294687: [libFuzzer] Use dynamic loading for External Functions on Windows..
Feb 9 2017, 5:47 PM
mpividori added inline comments to D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..
Feb 9 2017, 5:38 PM
mpividori added inline comments to D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..
Feb 9 2017, 5:19 PM
mpividori added a reviewer for D29751: [libFuzzer] Use dynamic loading for External Functions on Windows.: amccarth.
Feb 9 2017, 4:59 PM
mpividori added a comment to D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..

@zturner @rnk Ok. This is the final diff necessary to support MT. What do you think?

Feb 9 2017, 4:40 PM
mpividori updated the diff for D29752: [libFuzzer] Export external functions..

@zturner Ok, thanks for your feedback. Done.

Feb 9 2017, 4:39 PM
mpividori updated the diff for D29752: [libFuzzer] Export external functions..

@kcc @zturner Now, I only modify the cmake file.

Feb 9 2017, 3:59 PM
mpividori updated the diff for D29752: [libFuzzer] Export external functions..

@kcc Ok, this final diff is the best I can do.
I tried to use an "export.def" file, but that is not possible because these symbols are optional. I mean, they are not always present.
In the "export.def" I can not specify a symbol as optional. If it is not defined the linker fails.

Feb 9 2017, 3:20 PM
mpividori committed rL294638: Add check-fuzzer to Asan buildbot on Windows..
Add check-fuzzer to Asan buildbot on Windows.
Feb 9 2017, 2:25 PM
mpividori closed D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows. by committing rL294638: Add check-fuzzer to Asan buildbot on Windows..
Feb 9 2017, 2:25 PM
mpividori updated the diff for D29752: [libFuzzer] Export external functions..

@kcc do you agree with this diff? I include the header in InitializeTest and BogusInitializeTest, the same that we do for CustomCrossOverTest and CustomMutatorTest.

Feb 9 2017, 2:06 PM
mpividori added a comment to D29752: [libFuzzer] Export external functions..

@kcc These tests pass on Darwin? I wonder if they pass, because we use dlsym on Darwin, so these functions should be exported, with visibility default.

Feb 9 2017, 1:32 PM
mpividori added a comment to D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..

@rnk We don't need .def files, because we use dllexport.

Feb 9 2017, 10:54 AM
mpividori committed rL294609: [windows] Fix test for cl driver..
[windows] Fix test for cl driver.
Feb 9 2017, 10:52 AM
mpividori committed rL294604: [windows] [asan] Add wholearchive flag when including asan_cxx lib..
[windows] [asan] Add wholearchive flag when including asan_cxx lib.
Feb 9 2017, 10:34 AM
mpividori closed D29754: [clang] Add linker flag "wholearchive" for asan_cxx. by committing rL294604: [windows] [asan] Add wholearchive flag when including asan_cxx lib..
Feb 9 2017, 10:34 AM
mpividori added inline comments to D29732: [buildbot] Use CmakeCommand.
Feb 9 2017, 10:33 AM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Ready to land?

Feb 9 2017, 10:19 AM
mpividori updated subscribers of D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..
Feb 9 2017, 10:14 AM
mpividori created D29754: [clang] Add linker flag "wholearchive" for asan_cxx..
Feb 9 2017, 1:30 AM
mpividori created D29752: [libFuzzer] Export external functions..
Feb 9 2017, 12:05 AM
mpividori created D29751: [libFuzzer] Use dynamic loading for External Functions on Windows..
Feb 9 2017, 12:02 AM

Feb 8 2017

mpividori abandoned D29749: [libFuzzer] Fix FuzzerExtFunctions when working with weak functions..
Feb 8 2017, 11:49 PM
mpividori created D29749: [libFuzzer] Fix FuzzerExtFunctions when working with weak functions..
Feb 8 2017, 10:11 PM
mpividori updated the diff for D29732: [buildbot] Use CmakeCommand.
Feb 8 2017, 4:47 PM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@gkistanova Ok. Done. Let me know if you agree with the last diff.

Feb 8 2017, 4:47 PM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@gkistanova Do you agree?

Feb 8 2017, 2:55 PM
mpividori created D29732: [buildbot] Use CmakeCommand.
Feb 8 2017, 2:54 PM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@gkistanova @rnk Thanks for your feedback.
I have included suggested changes.
Unfortunately, I can't use MT for now. There is a problem with clang driver, and the order of static libraries. I will file a bug in bugzilla.
I still need to update the code to use CmakeCommand. Maybe in a different diff?

Feb 8 2017, 1:44 PM
mpividori added inline comments to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..
Feb 8 2017, 11:01 AM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Let mw know if you agree with this diff. I use Interpolate() and I update PATH in the slave_env.

Feb 8 2017, 11:01 AM
mpividori added inline comments to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..
Feb 8 2017, 10:56 AM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@zturner I am modifying the Property('slave_env') dictionary. I update the value mapped to the key: Path , to add the new directories.

Feb 8 2017, 9:07 AM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Done. Let me know if you agree. Do I need a special permission to push the commit?

Feb 8 2017, 8:49 AM

Feb 7 2017

mpividori committed rL294409: [sanitizer] Add weak hooks for Windows..
[sanitizer] Add weak hooks for Windows.
Feb 7 2017, 10:43 PM
mpividori closed D29562: [sanitizer] Add weak hooks for Windows, by committing rL294409: [sanitizer] Add weak hooks for Windows..
Feb 7 2017, 10:43 PM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Ok. Now it should work fine. Would you agree?

Feb 7 2017, 6:24 PM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@rnk Ah you mean: abspath . Ok I got it.

Feb 7 2017, 5:31 PM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

@rnk I am not sure I understand what you mean. All the steps will be executed in the same machine, won't they? So, after building clang and compiler-rt with MSVC, we have the binaries and libraries in build_dir\Release . I am adding them to PATH.

Feb 7 2017, 5:30 PM
mpividori abandoned D28438: [libFuzzer] Update implementation of sanitizer coverage to work when guards are initialized to 0xffffffff..
Feb 7 2017, 4:17 PM
mpividori abandoned D28437: [compiler-rt] Update implementation of sanitizer coverage to work when guards are initialized to 0xffffffff..
Feb 7 2017, 4:17 PM
mpividori abandoned D28436: [Sanitizer Coverage] Modify initialization of array bounds for sanitizer coverage..
Feb 7 2017, 4:17 PM
mpividori accepted D29683: [sanitizer] if WINAPI is already defined, do not redefine it.
Feb 7 2017, 4:16 PM
mpividori committed rL294389: [libFuzzer] Use custom target instead of list of binaries for tests..
[libFuzzer] Use custom target instead of list of binaries for tests.
Feb 7 2017, 4:15 PM
mpividori committed rL294390: [libFuzzer] Use long long to ensure 64 bits..
[libFuzzer] Use long long to ensure 64 bits.
Feb 7 2017, 4:15 PM
mpividori closed D29593: [libFuzzer] Use custom target instead of list of binaries for tests. by committing rL294389: [libFuzzer] Use custom target instead of list of binaries for tests..
Feb 7 2017, 4:15 PM
mpividori closed D29617: [libFuzzer] Use long long to ensure 64 bits. by committing rL294390: [libFuzzer] Use long long to ensure 64 bits..
Feb 7 2017, 4:15 PM
mpividori committed rL294387: [libFuzzer] Change Uninstrumented test name..
[libFuzzer] Change Uninstrumented test name.
Feb 7 2017, 4:14 PM
mpividori committed rL294388: [libFuzzer] Properly use Handle instead of FD on Windows..
[libFuzzer] Properly use Handle instead of FD on Windows.
Feb 7 2017, 4:14 PM
mpividori committed rL294386: [libFuzzer] fuzzer-jobs requires posix..
[libFuzzer] fuzzer-jobs requires posix.
Feb 7 2017, 4:14 PM
mpividori closed D29548: [libFuzzer] Fix close_fd_mask. by committing rL294388: [libFuzzer] Properly use Handle instead of FD on Windows..
Feb 7 2017, 4:14 PM
mpividori closed D29549: [libFuzzer] Change Uninstrumented test name. by committing rL294387: [libFuzzer] Change Uninstrumented test name..
Feb 7 2017, 4:14 PM
mpividori committed rL294384: [libFuzzer] Don't add newline character when using echo in tests..
[libFuzzer] Don't add newline character when using echo in tests.
Feb 7 2017, 4:14 PM
mpividori committed rL294385: [libFuzzer] Update fuzzer.test to properly set environment variables..
[libFuzzer] Update fuzzer.test to properly set environment variables.
Feb 7 2017, 4:14 PM
mpividori committed rL294383: [libFuzzer] Disable ulimit test on windows..
[libFuzzer] Disable ulimit test on windows.
Feb 7 2017, 4:14 PM
mpividori committed rL294382: [libFuzzer] Remove ? wildcard on tests..
[libFuzzer] Remove ? wildcard on tests.
Feb 7 2017, 4:14 PM
mpividori closed D29536: [libFuzzer] Don't add newline character when using echo in tests. by committing rL294384: [libFuzzer] Don't add newline character when using echo in tests..
Feb 7 2017, 4:14 PM
mpividori closed D29535: [libFuzzer] ulimit not implemented for Windows. by committing rL294383: [libFuzzer] Disable ulimit test on windows..
Feb 7 2017, 4:14 PM
mpividori closed D29537: [libFuzzer] Update fuzzer.test to properly set environment variables. by committing rL294385: [libFuzzer] Update fuzzer.test to properly set environment variables..
Feb 7 2017, 4:14 PM
mpividori closed D29534: [libFuzzer] Can't use wildcard ? for Windows. by committing rL294382: [libFuzzer] Remove ? wildcard on tests..
Feb 7 2017, 4:14 PM
mpividori committed rL294381: [libFuzzer] Update fuzzer-segv to set environment variables..
[libFuzzer] Update fuzzer-segv to set environment variables.
Feb 7 2017, 4:14 PM
mpividori committed rL294380: [libFuzzer] Properly configure tests for Windows..
[libFuzzer] Properly configure tests for Windows.
Feb 7 2017, 4:14 PM
mpividori committed rL294379: [libFuzzer] Simplify dump_coverage test..
[libFuzzer] Simplify dump_coverage test.
Feb 7 2017, 4:14 PM
mpividori closed D29532: [libFuzzer] Simplify test to work on windows. by committing rL294379: [libFuzzer] Simplify dump_coverage test..
Feb 7 2017, 4:14 PM
mpividori closed D29533: [libFuzzer] Update tests with environment variables. by committing rL294381: [libFuzzer] Update fuzzer-segv to set environment variables..
Feb 7 2017, 4:14 PM
mpividori closed D29529: [libFuzzer] Properly configure tests for Windows. by committing rL294380: [libFuzzer] Properly configure tests for Windows..
Feb 7 2017, 4:14 PM
mpividori committed rL294377: [libFuzzer] Update test to consider different exceptions..
[libFuzzer] Update test to consider different exceptions.
Feb 7 2017, 4:13 PM
mpividori committed rL294378: [libFuzzer] Update Load test to work on 32 bits..
[libFuzzer] Update Load test to work on 32 bits.
Feb 7 2017, 4:13 PM
mpividori closed D29602: [libFuzzer] Fix Load test. by committing rL294378: [libFuzzer] Update Load test to work on 32 bits..
Feb 7 2017, 4:13 PM
mpividori closed D29531: [libFuzzer] Consider exception names on tests. by committing rL294377: [libFuzzer] Update test to consider different exceptions..
Feb 7 2017, 4:13 PM
mpividori committed rL294376: [libFuzzer] Temporarily fix Shmem for Windows..
[libFuzzer] Temporarily fix Shmem for Windows.
Feb 7 2017, 4:13 PM
mpividori closed D29544: [libFuzzer] Stubs for shared memory on Windows. by committing rL294376: [libFuzzer] Temporarily fix Shmem for Windows..
Feb 7 2017, 4:13 PM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Use os.path.join instead of backslashes.

Feb 7 2017, 4:08 PM
mpividori added a comment to D29683: [sanitizer] if WINAPI is already defined, do not redefine it.

Is minwindef.h provided by MSVC?

Feb 7 2017, 3:58 PM
mpividori updated the diff for D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

+ Split build and testing into 2 steps so it is easier to understand when it fails.
+ Add asan dll path to Path, so it is found when executing the tests.
+ Add bin dir to Path, so tools like FileCheck, not and sancov are found when executing the tests.

Feb 7 2017, 3:49 PM
mpividori added inline comments to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..
Feb 7 2017, 1:12 PM
mpividori added a comment to D29617: [libFuzzer] Use long long to ensure 64 bits..

@kcc do you agree with these changes?

Feb 7 2017, 1:10 PM
mpividori added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Zturner, but I added llvm-commit when I created the diff. It looks like it doesnt work...

Feb 7 2017, 1:08 PM
mpividori created D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..
Feb 7 2017, 1:05 PM

Feb 6 2017

mpividori abandoned D29546: [libFuzzer] Improve fuzzer-jobs test for Posix..
Feb 6 2017, 6:47 PM
mpividori abandoned D29551: [libFuzzer] Failing tests on Windows.

After https://reviews.llvm.org/D29617 all tests pass on Windows.

Feb 6 2017, 6:46 PM
mpividori updated the diff for D29617: [libFuzzer] Use long long to ensure 64 bits..
Feb 6 2017, 6:45 PM
mpividori created D29617: [libFuzzer] Use long long to ensure 64 bits..
Feb 6 2017, 6:43 PM
mpividori updated the diff for D29532: [libFuzzer] Simplify test to work on windows..
Feb 6 2017, 3:51 PM
mpividori added a comment to D29546: [libFuzzer] Improve fuzzer-jobs test for Posix..

kill -0 ${FUZZER_PID}; only checks if the process if running and waits until it finishes with the while loop. But the condition could be false the first time you check. I mean, you are not checking if the process is still running after 2 seconds, you are only waiting.
Because of that, I modified the test to:

  • First check if the process is running: ` kill -0 ${FUZZER_PID} ` This retuns non-zero value if the process is not running.

Your description of what kill -O ${FUZZER_PID} is right but I think your change is wrong. If any RUN: lines fail then the test as a whole test will fail. That's how lit shell tests work. This means your change to the test will non-deterministically fail depending on when LLVMFuzzer-EmptyTest exits. We don't want that.

Feb 6 2017, 3:39 PM
mpividori retitled D29537: [libFuzzer] Update fuzzer.test to properly set environment variables. from [libFuzzer] fuzzer.test - separate tests with environment variables. to [libFuzzer] Update fuzzer.test to properly set environment variables..
Feb 6 2017, 2:51 PM
mpividori retitled D29533: [libFuzzer] Update tests with environment variables. from [libFuzzer] Separate tests with environment variables. to [libFuzzer] Update tests with environment variables..
Feb 6 2017, 2:50 PM
mpividori updated the diff for D29546: [libFuzzer] Improve fuzzer-jobs test for Posix..
Feb 6 2017, 2:48 PM
mpividori added a reviewer for D29546: [libFuzzer] Improve fuzzer-jobs test for Posix.: delcypher.
Feb 6 2017, 2:46 PM
mpividori added a comment to D29531: [libFuzzer] Consider exception names on tests..

@kcc now it looks good?

Feb 6 2017, 2:40 PM
mpividori abandoned D29547: [libFuzzer] Split fuzzer-jobs for different platforms..
Feb 6 2017, 2:39 PM
mpividori added a comment to D29562: [sanitizer] Add weak hooks for Windows,.

@alekseyshl Do you agree with these changes?

Feb 6 2017, 2:39 PM