This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] [Assembler] option to disable negative immediate conversions
ClosedPublic

Authored by sanwou01 on Mar 22 2017, 8:23 AM.

Details

Summary

Similar to the ARM target in https://reviews.llvm.org/rL298380, this
patch adds identical infrastructure for disabling negative immediate
conversions, and converts the existing aliases to the new infrastucture.

Event Timeline

sanwou01 created this revision.Mar 22 2017, 8:23 AM

Hi Sanne,

I think just the testing needs tightening up. Should we also be changing (and testing) the compare immediate aliases too?

cheers,
sam

test/MC/AArch64/alias-addsubimm.s
5

There's no RUN line that checks CHECK-NO-NEG-IMM.

sanwou01 updated this revision to Diff 93147.Mar 27 2017, 9:57 AM

Also mark cmn<->cmp as substitions and add a RUN: line to a test.

sanwou01 marked an inline comment as done.EditedMar 27 2017, 10:00 AM

Hi Sam,

Good catches on both accounts! I've added the missing RUN line, which then pointed towards the cmp<->cmn substitution. Note that those tests are at the bottom of the (unfortunately-named) alias-addsubimm.s.

Thanks!
Sanne

samparker accepted this revision.Mar 28 2017, 2:44 AM

Cheers Sanne, LGTM

This revision is now accepted and ready to land.Mar 28 2017, 2:44 AM
This revision was automatically updated to reflect the committed changes.