[LLC] Add an inline assembly diagnostics handler.

[sanwou01]

Summary

llc would hit a fatal error for errors in inline assembly. The
diagnostics message is now printed.

[anemet]

Do we already have this set up for clang?

[sanwou01]

In D29408#663648, @anemet wrote:

Do we already have this set up for clang?

Yes, see .../clang/lib/CodeGen/CodeGenAction.cpp .

[anemet]

Pretty straight-foward, LGTM.

test/CodeGen/AArch64/mature-mc-support.ll

 ; Test that inline assembly is parsed by the MC layer when MC support is mature
 ; (even when the output is assembly).
 
 ; RUN: not llc -mtriple=aarch64-pc-linux < %s > /dev/null 2> %t3
 ; RUN: FileCheck %s < %t3
 
 ; RUN: not llc -mtriple=aarch64-pc-linux -filetype=obj < %s > /dev/null 2> %t4
 ; RUN: FileCheck %s < %t4
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/ARM/mature-mc-support.ll

 ; Test that inline assembly is parsed by the MC layer when MC support is mature
 ; (even when the output is assembly).
 
 ; RUN: not llc -mtriple=arm-pc-linux < %s > /dev/null 2> %t1
 ; RUN: FileCheck %s < %t1
 
 ; RUN: not llc -mtriple=arm-pc-linux -filetype=obj < %s > /dev/null 2> %t2
 ; RUN: FileCheck %s < %t2
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/Mips/mature-mc-support.ll

 ; SKIP: not llc -march=mips64el < %s > /dev/null 2> %t7
 ; SKIP: FileCheck %s < %t7
 
 ; RUN: not llc -march=mips64el -filetype=obj < %s > /dev/null 2> %t8
 ; RUN: FileCheck %s < %t8
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/PowerPC/mature-mc-support.ll

 ; SKIP: not llc -march=ppc64le < %s > /dev/null 2> %t5
 ; SKIP: FileCheck %s < %t5
 
 ; SKIP: not llc -march=ppc64le -filetype=obj < %s > /dev/null 2> %t6
 ; SKIP: FileCheck %s < %t6
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/SPARC/mature-mc-support.ll

 ; SKIP: not llc -march=sparcv9 < %s > /dev/null 2> %t3
 ; SKIP: FileCheck %s < %t3
 
 ; RUN: not llc -march=sparcv9 -filetype=obj < %s > /dev/null 2> %t4
 ; RUN: FileCheck %s < %t4
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/SystemZ/mature-mc-support.ll

 ; Test that inline assembly is parsed by the MC layer when MC support is mature
 ; (even when the output is assembly).
 ; FIXME: SystemZ doesn't use the integrated assembler by default so we only test
 ; that -filetype=obj tries to parse the assembly.
 
 ; SKIP: not llc -march=systemz < %s > /dev/null 2> %t1
 ; SKIP: FileCheck %s < %t1
 
 ; RUN: not llc -march=systemz -filetype=obj < %s > /dev/null 2> %t2
 ; RUN: FileCheck %s < %t2
 
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/Thumb/mature-mc-support.ll

 ; Test that inline assembly is parsed by the MC layer when MC support is mature
 ; (even when the output is assembly).
 
 ; RUN: not llc -mtriple=thumb-pc-linux < %s > /dev/null 2> %t1
 ; RUN: FileCheck %s < %t1
 
 ; RUN: not llc -mtriple=thumb-pc-linux -filetype=obj < %s > /dev/null 2> %t2
 ; RUN: FileCheck %s < %t2
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

test/CodeGen/X86/mature-mc-support.ll

 ; RUN: not llc -march=x86-64 < %s > /dev/null 2> %t3
 ; RUN: FileCheck %s < %t3
 
 ; RUN: not llc -march=x86-64 -filetype=obj < %s > /dev/null 2> %t4
 ; RUN: FileCheck %s < %t4
 
 module asm " .this_directive_is_very_unlikely_to_exist"
 
-; CHECK: LLVM ERROR: Error parsing inline asm
+; CHECK: error: unknown directive

tools/llc/llc.cpp

if (!Remark->isEnabled())
       return;
 
   DiagnosticPrinterRawOStream DP(errs());
   errs() << LLVMContext::getDiagnosticMessagePrefix(DI.getSeverity()) << ": ";
   DI.print(DP);
   errs() << "\n";
 }
 
+static void InlineAsmDiagHandler(const SMDiagnostic &SMD, void *Context,
+                                 unsigned) {
+  bool *HasError = static_cast<bool *>(Context);
+  if (SMD.getKind() == SourceMgr::DK_Error)
+    *HasError = true;
+
+  SMD.print(nullptr, errs());
+}
+
 // main - Entry point for the llc compiler.
 //
 int main(int argc, char **argv) {
   sys::PrintStackTraceOnErrorSignal(argv[0]);
   PrettyStackTraceProgram X(argc, argv);
 
   // Enable debug stream buffering.
   EnableDebugBuffering = true;
int main(int argc, char **argv) {
 
   cl::ParseCommandLineOptions(argc, argv, "llvm system compiler\n");
 
   Context.setDiscardValueNames(DiscardValueNames);
 
   // Set a diagnostic handler that doesn't exit on the first error
   bool HasError = false;
   Context.setDiagnosticHandler(DiagnosticHandler, &HasError);
+  Context.setInlineAsmDiagnosticHandler(InlineAsmDiagHandler, &HasError);
+
   if (PassRemarksWithHotness)
     Context.setDiagnosticHotnessRequested(true);
 
   std::unique_ptr<tool_output_file> YamlFile;
   if (RemarksFilename != "") {
     std::error_code EC;
     YamlFile = llvm::make_unique<tool_output_file>(RemarksFilename, EC,
                                                    sys::fs::F_None);