Page MenuHomePhabricator

[Assembler] Always copy temp inline assembly string.
AbandonedPublic

Authored by sanwou01 on Feb 1 2017, 11:44 AM.

Details

Summary

This ensures that string (which was previously kept on the stack) is
still alive during finalization.

Event Timeline

sanwou01 created this revision.Feb 1 2017, 11:44 AM
rengolin added inline comments.Feb 1 2017, 2:16 PM
lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
115

Str is an argument, so guaranteed (on a single thread) to exist through the execution of this function, no?

Or is this about the report_fatal_error at the end, which could print garbage?

sanwou01 abandoned this revision.Feb 8 2017, 1:49 AM

Ready to land as D29441.