Page MenuHomePhabricator

[Assembler] Enable nicer diagnostics for inline assembly.
AbandonedPublic

Authored by sanwou01 on Feb 1 2017, 11:53 AM.

Details

Summary

When a regular SrcMgr is not available, which is the case for inline
assembly, use the InlineSrcMgr to report diagnostics instead of using
the generic report_fatal_error().

Event Timeline

sanwou01 created this revision.Feb 1 2017, 11:53 AM
rengolin edited edge metadata.Feb 1 2017, 2:22 PM

This is simple and makes sense. But all the other inline asm look correlated. Since you marked as dependencies, and phab is not really great to handle deps, can I ask you a favour?

Try to join all inline asm reporting dependencies into a new patch (don't mess up the existing ones), just so we see how it looks like.

At least the squashed patch will give us an overview or what they accomplish. It may even make more sense to commit squashed, in case we need to revert one in between, reverting a single patch is easier than 5. :)

cheers,
--renato

sanwou01 abandoned this revision.Feb 8 2017, 1:48 AM

Ready to land as D29441.