In Preparation for graph comparison, this patch breaks out the color
choice code from xray-graph into a library and adds polynomials for
the Sequential and Difference sets from ColorBrewer.
Depends on D29005
Paths
| Differential D29363
[XRAY] A Color Choosing helper for XRay Graph ClosedPublic Authored by varno on Jan 31 2017, 6:25 PM.
Details Summary In Preparation for graph comparison, this patch breaks out the color Depends on D29005
Diff Detail
Event Timelinevarno added a child revision: D29320: [XRay] A tool for Comparing xray function call graphs.Jan 31 2017, 6:30 PM dberris added inline comments.
This revision now requires changes to proceed.Feb 2 2017, 10:04 PM varno added inline comments.
dberris added inline comments.
This revision now requires changes to proceed.Feb 7 2017, 1:08 AM varno edited edge metadata. Comment Actions
Comment Actions Almost there...
This revision now requires changes to proceed.Feb 9 2017, 12:01 AM varno edited edge metadata. Comment Actions
This revision is now accepted and ready to land.Feb 9 2017, 9:47 PM Comment Actions Sorry to jump in with a peanut gallery comment, but just wanted to push back on some of the complexity we're adding here.
This revision now requires changes to proceed.Feb 15 2017, 6:22 PM
Comment Actions
Comment Actions (FWIW, I like the more minimal schemes here. We have a couple of sequential ones, and a solid divergent ones. Enough to be very useful, but no more than we really have use cases for today. That part LGTM, but leaving the code review proper to others.) Closed by commit rL296210: [XRAY] A Color Choosing helper for XRay Graph (authored by dberris). · Explain WhyFeb 24 2017, 4:38 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 87942 test/tools/llvm-xray/X86/graph-color-simple-case.yaml
tools/llvm-xray/CMakeLists.txt
tools/llvm-xray/xray-color-helper-gen.wls
tools/llvm-xray/xray-color-helper.h
tools/llvm-xray/xray-color-helper.cc
tools/llvm-xray/xray-graph.h
tools/llvm-xray/xray-graph.cc
|
Probably needs top-matter to bear the correct license.