This is an archive of the discontinued LLVM Phabricator instance.

[clang] Add linker flag when including "asan_dynamic_runtime_thunk".
ClosedPublic

Authored by mpividori on Jan 25 2017, 4:43 PM.

Details

Summary

I need to modify clang driver for windows to include: -wholearchive:asan_dynamic_runtime_thunk, so all the object files in the static library: asan_dynamic_runtime_thunk are considered by the linker. This is necessary, because some object files only include linker pragmas, and doesn't resolve any symbol, so if we don't include that flag, the linker will ignore them, and won't read the linker pragmas.

Diff Detail

Event Timeline

mpividori created this revision.Jan 25 2017, 4:43 PM
zturner edited edge metadata.Jan 26 2017, 11:06 AM

seems reasonable to me, but I will let rnk@ give final lgtm.

mpividori updated this revision to Diff 85964.Jan 26 2017, 1:53 PM

I fix a test for clang driver, that was failing with this modification.

rnk accepted this revision.Jan 26 2017, 4:06 PM

lgtm

This revision is now accepted and ready to land.Jan 26 2017, 4:06 PM
This revision was automatically updated to reflect the committed changes.